Skip to content

Commit dec11c2

Browse files
Mark-SimulacrumMark-Simulacrum
authored
Merge pull request #1550 from Mark-Simulacrum/triage
Add triage for this week
2 parents 611e4a2 + b909c03 commit dec11c2

File tree

1 file changed

+192
-0
lines changed

1 file changed

+192
-0
lines changed

‎triage/2023-03-14.md

Lines changed: 192 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,192 @@
1+
# 2023-03-14 Triage Log
2+
3+
A fairly mixed week, with several significant improvements and a few
4+
significant regressions. On average, this week saw a slight increase in compile
5+
times.
6+
7+
Triage done by **@simulacrum**.
8+
Revision range: [8f9e09ac3ef3fa85d23ad6a0c920d49987144b13..0058748944abb3282aba0e0a74823c6411703565](https://perf.rust-lang.org/?start=8f9e09ac3ef3fa85d23ad6a0c920d49987144b13&end=0058748944abb3282aba0e0a74823c6411703565&absolute=false&stat=instructions%3Au)
9+
10+
**Summary**:
11+
12+
| (instructions:u) | mean | range | count |
13+
|:----------------------------------:|:-----:|:---------------:|:-----:|
14+
| Regressions ❌ <br /> (primary) | 1.8% | [0.3%, 6.7%] | 52 |
15+
| Regressions ❌ <br /> (secondary) | 12.3% | [0.2%, 139.9%] | 45 |
16+
| Improvements ✅ <br /> (primary) | -0.9% | [-2.8%, -0.2%] | 45 |
17+
| Improvements ✅ <br /> (secondary) | -2.2% | [-11.2%, -0.2%] | 52 |
18+
| All ❌✅ (primary) | 0.5% | [-2.8%, 6.7%] | 97 |
19+
20+
21+
4 Regressions, 6 Improvements, 4 Mixed; 2 of them in rollups
22+
39 artifact comparisons made in total
23+
24+
#### Regressions
25+
26+
Update cargo [#108665](https://github.com/rust-lang/rust/pull/108665) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7c306f6dcd600b1fcc74439c780e8ebef338d84c&end=900c3540378c8422b8087ffa3db60fa6c8abfcad&stat=instructions:u)
27+
28+
| (instructions:u) | mean | range | count |
29+
|:----------------------------------:|:-----:|:--------------:|:-----:|
30+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.4%] | 8 |
31+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.5%] | 13 |
32+
| Improvements ✅ <br /> (primary) | - | - | 0 |
33+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 2 |
34+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.4%] | 8 |
35+
36+
Noise, most likely, based on small deltas. Marked as triaged.
37+
38+
Make RPITITs simple cases work when using lower_impl_trait_in_trait_to_assoc_ty [#108700](https://github.com/rust-lang/rust/pull/108700) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=542ed2bf72b232b245ece058fc11aebb1ca507d7&end=9455a5591b1435dfc9a88b2922d0dfc155d9614f&stat=instructions:u)
39+
40+
| (instructions:u) | mean | range | count |
41+
|:----------------------------------:|:-----:|:--------------:|:-----:|
42+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 1.2%] | 93 |
43+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.2%, 2.9%] | 45 |
44+
| Improvements ✅ <br /> (primary) | - | - | 0 |
45+
| Improvements ✅ <br /> (secondary) | -1.5% | [-1.5%, -1.5%] | 1 |
46+
| All ❌✅ (primary) | 0.6% | [0.2%, 1.2%] | 93 |
47+
48+
Regressions largely resolved in
49+
[#109057](https://github.com/rust-lang/rust/pull/109057); essentially all
50+
regressions are to incremental workloads.
51+
52+
Move `Option::as_slice` to an always-sound implementation [#108623](https://github.com/rust-lang/rust/pull/108623) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f1b1ed7e18f1fbe5226a96626827c625985f8285&end=cf8d98b227fd3c7e50aa5a9453141c5edbf5df38&stat=instructions:u)
53+
54+
| (instructions:u) | mean | range | count |
55+
|:----------------------------------:|:----:|:------------:|:-----:|
56+
| Regressions ❌ <br /> (primary) | 0.8% | [0.8%, 0.9%] | 3 |
57+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.4%, 0.7%] | 3 |
58+
| Improvements ✅ <br /> (primary) | - | - | 0 |
59+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
60+
| All ❌✅ (primary) | 0.8% | [0.8%, 0.9%] | 3 |
61+
62+
Minor regressions in incremental scenarios for a few workloads; not concerning
63+
enough to warrant further investigation.
64+
65+
Rollup of 9 pull requests [#109097](https://github.com/rust-lang/rust/pull/109097) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=22f247c6f3ed388cb702d01c2ff27da658a8b353&end=c54af457d05722321ca88c2ae0e5706ef803c5fb&stat=instructions:u)
66+
67+
| (instructions:u) | mean | range | count |
68+
|:----------------------------------:|:-----:|:--------------:|:-----:|
69+
| Regressions ❌ <br /> (primary) | 0.9% | [0.3%, 2.7%] | 17 |
70+
| Regressions ❌ <br /> (secondary) | 3.6% | [0.6%, 11.4%] | 17 |
71+
| Improvements ✅ <br /> (primary) | - | - | 0 |
72+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.3%] | 2 |
73+
| All ❌✅ (primary) | 0.9% | [0.3%, 2.7%] | 17 |
74+
75+
Regression triaged to "Treat projections with infer as placeholder during fast
76+
reject in new solver" [#108830](https://github.com/rust-lang/rust/pull/108830).
77+
Pinged author/reviewer on that PR.
78+
79+
#### Improvements
80+
81+
Move dep graph methods to DepGraphData to avoid branches and `unwrap`s [#108417](https://github.com/rust-lang/rust/pull/108417) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8a73f50d875840b8077b8ec080fa41881d7ce40d&end=542ed2bf72b232b245ece058fc11aebb1ca507d7&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 6 |
88+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.2%] | 5 |
89+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.2%] | 6 |
90+
91+
92+
Avoid unnecessary hashing [#108794](https://github.com/rust-lang/rust/pull/108794) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=501ad021b9a4fb2cd6a39e0302d22f169f6166b0&end=150cb381471533050751111e5faf1d9f05c02f77&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:---------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
98+
| Improvements ✅ <br /> (primary) | -0.8% | [-2.9%, -0.2%] | 68 |
99+
| Improvements ✅ <br /> (secondary) | -2.0% | [-11.3%, -0.2%] | 53 |
100+
| All ❌✅ (primary) | -0.8% | [-2.9%, -0.2%] | 68 |
101+
102+
103+
rustdoc: reduce allocs in FnDecl::inner_full_print [#109011](https://github.com/rust-lang/rust/pull/109011) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b05bb2900825e4d063ebf3f0f11afb08baed3bc6&end=d610b0c514b9ccb0dad5d0b77ce4c518f71b92c8&stat=instructions:u)
104+
105+
| (instructions:u) | mean | range | count |
106+
|:----------------------------------:|:-----:|:--------------:|:-----:|
107+
| Regressions ❌ <br /> (primary) | - | - | 0 |
108+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
109+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.0%, -0.4%] | 7 |
110+
| Improvements ✅ <br /> (secondary) | -0.7% | [-2.3%, -0.3%] | 8 |
111+
| All ❌✅ (primary) | -0.7% | [-1.0%, -0.4%] | 7 |
112+
113+
114+
:arrow_up: `rust-analyzer` [#109069](https://github.com/rust-lang/rust/pull/109069) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cf8d98b227fd3c7e50aa5a9453141c5edbf5df38&end=8efa635b40ce6569e12f4988b7a9bcb7f3f0ed0c&stat=instructions:u)
115+
116+
| (instructions:u) | mean | range | count |
117+
|:----------------------------------:|:-----:|:--------------:|:-----:|
118+
| Regressions ❌ <br /> (primary) | - | - | 0 |
119+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
120+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.8%, -0.7%] | 3 |
121+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.7%, -0.3%] | 2 |
122+
| All ❌✅ (primary) | -0.7% | [-0.8%, -0.7%] | 3 |
123+
124+
125+
resolve: Querify most cstore access methods (subset) [#108992](https://github.com/rust-lang/rust/pull/108992) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c54af457d05722321ca88c2ae0e5706ef803c5fb&end=bd43458d4c2a01af55f7032f7c47d7c8fecfe560&stat=instructions:u)
126+
127+
| (instructions:u) | mean | range | count |
128+
|:----------------------------------:|:-----:|:--------------:|:-----:|
129+
| Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.5%] | 1 |
130+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
131+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.2%, -0.2%] | 15 |
132+
| Improvements ✅ <br /> (secondary) | -1.6% | [-2.1%, -1.1%] | 2 |
133+
| All ❌✅ (primary) | -0.4% | [-1.2%, 0.5%] | 16 |
134+
135+
136+
Don't `opt_rpitit_info` as a separate query [#109057](https://github.com/rust-lang/rust/pull/109057) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bd43458d4c2a01af55f7032f7c47d7c8fecfe560&end=0058748944abb3282aba0e0a74823c6411703565&stat=instructions:u)
137+
138+
| (instructions:u) | mean | range | count |
139+
|:----------------------------------:|:-----:|:--------------:|:-----:|
140+
| Regressions ❌ <br /> (primary) | - | - | 0 |
141+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
142+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.1%, -0.2%] | 86 |
143+
| Improvements ✅ <br /> (secondary) | -1.2% | [-2.7%, -0.2%] | 38 |
144+
| All ❌✅ (primary) | -0.5% | [-1.1%, -0.2%] | 86 |
145+
146+
147+
#### Mixed
148+
149+
always resolve to universal regions if possible [#108121](https://github.com/rust-lang/rust/pull/108121) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=60445fda58fc9f9aa413752530d6756ae5570f2f&end=7c306f6dcd600b1fcc74439c780e8ebef338d84c&stat=instructions:u)
150+
151+
| (instructions:u) | mean | range | count |
152+
|:----------------------------------:|:-----:|:--------------:|:-----:|
153+
| Regressions ❌ <br /> (primary) | - | - | 0 |
154+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.7%, 0.7%] | 2 |
155+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 3 |
156+
| Improvements ✅ <br /> (secondary) | -1.4% | [-1.7%, -0.7%] | 9 |
157+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.2%] | 3 |
158+
159+
160+
Do not consider `&mut *x` as mutating `x` in `CopyProp` [#108178](https://github.com/rust-lang/rust/pull/108178) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6a179026decb823e6ad8ba1c81729528bc5d695f&end=66a2d6221069e0d08ceacf2a3201600e2092d2e0&stat=instructions:u)
161+
162+
| (instructions:u) | mean | range | count |
163+
|:----------------------------------:|:-----:|:--------------:|:-----:|
164+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 1.0%] | 18 |
165+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.5%] | 11 |
166+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 2 |
167+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
168+
| All ❌✅ (primary) | 0.3% | [-0.3%, 1.0%] | 20 |
169+
170+
171+
Rollup of 8 pull requests [#108934](https://github.com/rust-lang/rust/pull/108934) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f37f8549940386a9d066ba199983affff47afbb4&end=104f4300cfddbd956e32820ef202a732f06ec848&stat=instructions:u)
172+
173+
| (instructions:u) | mean | range | count |
174+
|:----------------------------------:|:-----:|:--------------:|:-----:|
175+
| Regressions ❌ <br /> (primary) | - | - | 0 |
176+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.5%, 1.1%] | 2 |
177+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.0%, -0.7%] | 2 |
178+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
179+
| All ❌✅ (primary) | -0.9% | [-1.0%, -0.7%] | 2 |
180+
181+
182+
Strengthen state tracking in const-prop [#108872](https://github.com/rust-lang/rust/pull/108872) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7b4f48927dce585f747a58083b45ab62b9d73a53&end=b05bb2900825e4d063ebf3f0f11afb08baed3bc6&stat=instructions:u)
183+
184+
| (instructions:u) | mean | range | count |
185+
|:----------------------------------:|:-----:|:--------------:|:-----:|
186+
| Regressions ❌ <br /> (primary) | 2.4% | [0.6%, 6.3%] | 30 |
187+
| Regressions ❌ <br /> (secondary) | 41.6% | [0.3%, 139.3%] | 12 |
188+
| Improvements ✅ <br /> (primary) | - | - | 0 |
189+
| Improvements ✅ <br /> (secondary) | -1.4% | [-1.9%, -1.0%] | 2 |
190+
| All ❌✅ (primary) | 2.4% | [0.6%, 6.3%] | 30 |
191+
192+
Regression triaged in [this comment](https://github.com/rust-lang/rust/pull/108178#issuecomment-1461875685).

0 commit comments

Comments
 (0)