Skip to content

Commit dfe94b3

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent 32a6ce2 commit dfe94b3

File tree

1 file changed

+185
-0
lines changed

1 file changed

+185
-0
lines changed

‎triage/2024-08-29.md

Lines changed: 185 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,185 @@
1+
# 2024-08-29 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [4fe1e2bd..acb4e8b6](https://perf.rust-lang.org/?start=4fe1e2bd5bf5a6f1cb245f161a5e9d315766f103&end=acb4e8b6251f1d8da36f08e7a70fa23fc581839e&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:---------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 2.3%] | 25 |
13+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.1%, 1.9%] | 16 |
14+
| Improvements ✅ <br /> (primary) | -1.4% | [-10.4%, -0.2%] | 54 |
15+
| Improvements ✅ <br /> (secondary) | -2.6% | [-8.1%, -0.3%] | 56 |
16+
| All ❌✅ (primary) | -0.8% | [-10.4%, 2.3%] | 79 |
17+
18+
19+
5 Regressions, 3 Improvements, 3 Mixed; 5 of them in rollups
20+
44 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Update stdarch submodule [#128866](https://github.com/rust-lang/rust/pull/128866) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4d7c095832494257a9f57e13fd151a9d4f5c6851&end=59a74db37df8628f778faf75faa41958bb07a42a&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.5%] | 2 |
29+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.7%] | 14 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.5%] | 2 |
33+
34+
35+
Rollup of 9 pull requests [#129365](https://github.com/rust-lang/rust/pull/129365) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a32d4a0e822a29a6682e08b75a8df4c29c7fa9f1&end=739b1fdb158a3216d1b592d0d79d77d256f59815&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 15 |
40+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 15 |
44+
45+
46+
Rollup of 9 pull requests [#129521](https://github.com/rust-lang/rust/pull/129521) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=697d9530d78aeba31458cadfc338adb2aea90bee&end=717aec0f8eebdc5eb51756e5129dde15e8b25710&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.7% | [0.4%, 0.9%] | 6 |
51+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.7% | [0.4%, 0.9%] | 6 |
55+
56+
57+
Rollup of 9 pull requests [#129632](https://github.com/rust-lang/rust/pull/129632) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=515395af0efdbdd657ff08a1f6d28e553856654f&end=bf662eb80838008acabc307dd64d84935ce3a20d&stat=instructions:u)
58+
59+
| (instructions:u) | mean | range | count |
60+
|:----------------------------------:|:----:|:------------:|:-----:|
61+
| Regressions ❌ <br /> (primary) | 1.4% | [0.6%, 2.3%] | 2 |
62+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
63+
| Improvements ✅ <br /> (primary) | - | - | 0 |
64+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
65+
| All ❌✅ (primary) | 1.4% | [0.6%, 2.3%] | 2 |
66+
67+
68+
Implement a first version of RFC 3525: struct target features [#127537](https://github.com/rust-lang/rust/pull/127537) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=100fde5246bf56f22fb5cc85374dd841296fce0e&end=acb4e8b6251f1d8da36f08e7a70fa23fc581839e&stat=instructions:u)
69+
70+
| (instructions:u) | mean | range | count |
71+
|:----------------------------------:|:----:|:------------:|:-----:|
72+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 1.0%] | 72 |
73+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.2%, 2.2%] | 19 |
74+
| Improvements ✅ <br /> (primary) | - | - | 0 |
75+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
76+
| All ❌✅ (primary) | 0.4% | [0.2%, 1.0%] | 72 |
77+
78+
79+
#### Improvements
80+
81+
Rollup of 9 pull requests [#129331](https://github.com/rust-lang/rust/pull/129331) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5aea14073eee9e403c3bb857490cd6aa4a395531&end=4d7c095832494257a9f57e13fd151a9d4f5c6851&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:---------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -3.2% | [-10.3%, -0.5%] | 19 |
88+
| Improvements ✅ <br /> (secondary) | -5.0% | [-7.4%, -1.4%] | 21 |
89+
| All ❌✅ (primary) | -3.2% | [-10.3%, -0.5%] | 19 |
90+
91+
92+
Do not call source_span when not tracking dependencies. [#129513](https://github.com/rust-lang/rust/pull/129513) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=600edc948ab5de7a92538bcc2f49cb8d47925e2d&end=ab869e094a907cc5d19b4080f22eccaf347f1f95&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:--------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
98+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 20 |
99+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.2%] | 3 |
100+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 20 |
101+
102+
103+
Get rid of `predicates_defined_on` [#129546](https://github.com/rust-lang/rust/pull/129546) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d9a2cc4daee38c63b2f69710ed61d40acc32b709&end=748c54848dc2964b7e133f945cabe5bc64079947&stat=instructions:u)
104+
105+
| (instructions:u) | mean | range | count |
106+
|:----------------------------------:|:-----:|:--------------:|:-----:|
107+
| Regressions ❌ <br /> (primary) | - | - | 0 |
108+
| Regressions ❌ <br /> (secondary) | 3.2% | [3.2%, 3.2%] | 1 |
109+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.3%, -0.2%] | 108 |
110+
| Improvements ✅ <br /> (secondary) | -0.7% | [-2.0%, -0.1%] | 68 |
111+
| All ❌✅ (primary) | -0.4% | [-1.3%, -0.2%] | 108 |
112+
113+
114+
#### Mixed
115+
116+
Rollup of 6 pull requests [#129275](https://github.com/rust-lang/rust/pull/129275) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5601d14249818d952da612fec481b7af3ed03a39&end=636d7ff91b9847d6d43c7bbe023568828f6e3246&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:--------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
121+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 8 |
122+
| Improvements ✅ <br /> (primary) | - | - | 0 |
123+
| Improvements ✅ <br /> (secondary) | -1.0% | [-1.0%, -1.0%] | 1 |
124+
| All ❌✅ (primary) | 0.2% | [0.2%, 0.2%] | 1 |
125+
126+
127+
Don't generate functions with the `rustc_intrinsic_must_be_overridden` attribute [#129239](https://github.com/rust-lang/rust/pull/129239) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a971212545766fdfe0dd68e5d968133f79944a19&end=4d5b3b196284aded6ae99d12bcf149ffdc8ef379&stat=instructions:u)
128+
129+
| (instructions:u) | mean | range | count |
130+
|:----------------------------------:|:-----:|:--------------:|:-----:|
131+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
132+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
133+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 2 |
134+
| Improvements ✅ <br /> (secondary) | -1.3% | [-2.2%, -0.6%] | 6 |
135+
| All ❌✅ (primary) | -0.1% | [-0.3%, 0.2%] | 3 |
136+
137+
138+
Add a precondition check for Layout::from_size_align_unchecked [#126556](https://github.com/rust-lang/rust/pull/126556) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=59a74db37df8628f778faf75faa41958bb07a42a&end=982c6f8721416431ec62bb0b9105c0578a9fc603&stat=instructions:u)
139+
140+
| (instructions:u) | mean | range | count |
141+
|:----------------------------------:|:-----:|:--------------:|:-----:|
142+
| Regressions ❌ <br /> (primary) | - | - | 0 |
143+
| Regressions ❌ <br /> (secondary) | 1.3% | [1.1%, 1.5%] | 3 |
144+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.5%, -0.2%] | 9 |
145+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
146+
| All ❌✅ (primary) | -0.3% | [-0.5%, -0.2%] | 9 |
147+
148+
149+
#### Untriaged Pull Requests
150+
151+
- [#129632 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/129632)
152+
- [#129521 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/129521)
153+
- [#129365 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/129365)
154+
- [#129275 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/129275)
155+
- [#129239 Don't generate functions with the `rustc_intrinsic_must_be_overridden` attribute](https://github.com/rust-lang/rust/pull/129239)
156+
- [#128936 Support reading thin archives in ArArchiveBuilder](https://github.com/rust-lang/rust/pull/128936)
157+
- [#128866 Update stdarch submodule](https://github.com/rust-lang/rust/pull/128866)
158+
- [#128443 Properly mark loop as diverging if it has no breaks](https://github.com/rust-lang/rust/pull/128443)
159+
- [#128357 Detect non-lifetime binder params shadowing item params](https://github.com/rust-lang/rust/pull/128357)
160+
- [#128301 Rollup of 3 pull requests](https://github.com/rust-lang/rust/pull/128301)
161+
- [#128169 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/128169)
162+
- [#128155 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/128155)
163+
- [#128104 Not lint pub structs without pub constructors intentionally](https://github.com/rust-lang/rust/pull/128104)
164+
- [#127998 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/127998)
165+
- [#127865 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/127865)
166+
- [#127537 Implement a first version of RFC 3525: struct target features](https://github.com/rust-lang/rust/pull/127537)
167+
- [#127528 Replace ASCII control chars with Unicode Control Pictures](https://github.com/rust-lang/rust/pull/127528)
168+
- [#127486 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/127486)
169+
- [#127439 Uplift elaboration into `rustc_type_ir`](https://github.com/rust-lang/rust/pull/127439)
170+
- [#127172 Make `can_eq` process obligations (almost) everywhere](https://github.com/rust-lang/rust/pull/127172)
171+
- [#127096 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/127096)
172+
- [#127076 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/127076)
173+
- [#126852 Also get `add nuw` from `uN::checked_add`](https://github.com/rust-lang/rust/pull/126852)
174+
- [#126591 [perf] More span update benchmarking](https://github.com/rust-lang/rust/pull/126591)
175+
- [#126578 Account for things that optimize out in inlining costs](https://github.com/rust-lang/rust/pull/126578)
176+
- [#126134 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/126134)
177+
- [#126024 Do not use global caches if opaque types can be defined](https://github.com/rust-lang/rust/pull/126024)
178+
- [#125968 Store the types of `ty::Expr` arguments in the `ty::Expr`](https://github.com/rust-lang/rust/pull/125968)
179+
- [#125824 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/125824)
180+
- [#125144 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/125144)
181+
182+
#### Nags requiring follow up
183+
184+
TODO: Nags
185+

0 commit comments

Comments
 (0)