Skip to content

Commit e036aa7

Browse files
rylevrylev
committed
Add perf triage for 2023-11-14
1 parent c19ca6a commit e036aa7

File tree

1 file changed

+109
-0
lines changed

1 file changed

+109
-0
lines changed

‎triage/2023-11-14.md

Lines changed: 109 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,109 @@
1+
# 2023-11-14 Triage Log
2+
3+
A week dominated by one particular perf improvement that lead to huge performance gains - an avg of 5% improvement across 121 test cases! The perf improvement comes from adding an `#[inline]` hint to the output from `#[derive(Debug)]` which presumably allows the compiler to more easily do deadcode elimination reducing the binary size and the amount of code that actually needs to be code-gened.
4+
5+
Triage done by **@rylev**.
6+
Revision range: [7b97a5ca..173b6e68](https://perf.rust-lang.org/?start=7b97a5ca8422d1495a8918106d3249aa405812d4&end=173b6e686b158dbad7d072c64bef3ced2052312b&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:---------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.9%] | 10 |
13+
| Regressions ❌ <br /> (secondary) | 1.9% | [0.2%, 3.6%] | 12 |
14+
| Improvements ✅ <br /> (primary) | -5.6% | [-49.2%, -0.1%] | 111 |
15+
| Improvements ✅ <br /> (secondary) | -3.5% | [-25.0%, -0.2%] | 155 |
16+
| All ❌✅ (primary) | -5.1% | [-49.2%, 0.9%] | 121 |
17+
18+
19+
2 Regressions, 2 Improvements, 3 Mixed; 3 of them in rollups
20+
55 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Bump libc dependency [#117617](https://github.com/rust-lang/rust/pull/117617) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9bd71afb90c2a6e0348cdd4a2b10a3bf39908f19&end=118a2deea5f7aba3de1ab13143a998b6bad13704&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:-------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 8.3% | [1.1%, 19.0%] | 9 |
29+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 8.3% | [1.1%, 19.0%] | 9 |
33+
- A curious perf infra glitch - the regression returned to normal after a few runs.
34+
35+
36+
Rollup of 6 pull requests [#117736](https://github.com/rust-lang/rust/pull/117736) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d8dbf7ca0ee9c6da0fd039b1eb8cf7c7cb840f43&end=492e57c6adeb9e7635e9dfb7bab591997edd7f98&stat=instructions:u)
37+
38+
| (instructions:u) | mean | range | count |
39+
|:----------------------------------:|:----:|:------------:|:-----:|
40+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.5%] | 5 |
41+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.6%, 0.6%] | 1 |
42+
| Improvements ✅ <br /> (primary) | - | - | 0 |
43+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
44+
| All ❌✅ (primary) | 0.4% | [0.2%, 0.5%] | 5 |
45+
- The only PR that includes actual changes to the compiler is [#117645](https://github.com/rust-lang/rust/pull/117645). Kicked off a test to see if that's the root cause.
46+
47+
48+
#### Improvements
49+
50+
Rollup of 4 pull requests [#117680](https://github.com/rust-lang/rust/pull/117680) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=118a2deea5f7aba3de1ab13143a998b6bad13704&end=7adc89b69b941afceadcf8609dd6b2999353e550&stat=instructions:u)
51+
52+
| (instructions:u) | mean | range | count |
53+
|:----------------------------------:|:-----:|:---------------:|:-----:|
54+
| Regressions ❌ <br /> (primary) | - | - | 0 |
55+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
56+
| Improvements ✅ <br /> (primary) | -9.1% | [-16.0%, -2.6%] | 7 |
57+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
58+
| All ❌✅ (primary) | -9.1% | [-16.0%, -2.6%] | 7 |
59+
- The flip side of [#117617](https://github.com/rust-lang/rust/pull/117617)'s strange perf regression.
60+
61+
62+
Add `std::hash::{DefaultHasher, RandomState}` exports (needs FCP) [#115694](https://github.com/rust-lang/rust/pull/115694) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ed086d86b8b224f7df2da09cf48ac2a654bf841e&end=2c1b65ee1431f8d3fe2142e821eb13c623bbf8a0&stat=instructions:u)
63+
64+
| (instructions:u) | mean | range | count |
65+
|:----------------------------------:|:-----:|:--------------:|:-----:|
66+
| Regressions ❌ <br /> (primary) | - | - | 0 |
67+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
68+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.2%, -0.4%] | 6 |
69+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
70+
| All ❌✅ (primary) | -0.9% | [-1.2%, -0.4%] | 6 |
71+
72+
73+
#### Mixed
74+
75+
Only use `normalize_param_env` when normalizing predicate in `check_item_bounds` [#117542](https://github.com/rust-lang/rust/pull/117542) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=750c2ecd1503fe7ff39e41603977d12de33417d8&end=fab1054e1742790c22ccc92a625736d658363677&stat=instructions:u)
76+
77+
| (instructions:u) | mean | range | count |
78+
|:----------------------------------:|:------:|:---------------:|:-----:|
79+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 1 |
80+
| Regressions ❌ <br /> (secondary) | 1.4% | [0.8%, 2.3%] | 12 |
81+
| Improvements ✅ <br /> (primary) | -18.4% | [-49.6%, -0.2%] | 20 |
82+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
83+
| All ❌✅ (primary) | -17.5% | [-49.6%, 0.4%] | 21 |
84+
- Fixing https://github.com/rust-lang/rust/pull/117131#issuecomment-1791852906 and deemed acceptable for the small regressions.
85+
86+
87+
Emit #[inline] on derive(Debug) [#117727](https://github.com/rust-lang/rust/pull/117727) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eae4135939881ae730342bd336ae6302c3787e27&end=0f44eb32f1123ac93ab404d74c295263ce468343&stat=instructions:u)
88+
89+
| (instructions:u) | mean | range | count |
90+
|:----------------------------------:|:-----:|:---------------:|:-----:|
91+
| Regressions ❌ <br /> (primary) | 3.1% | [0.3%, 13.7%] | 5 |
92+
| Regressions ❌ <br /> (secondary) | 1.8% | [0.2%, 3.4%] | 6 |
93+
| Improvements ✅ <br /> (primary) | -2.3% | [-10.6%, -0.1%] | 110 |
94+
| Improvements ✅ <br /> (secondary) | -3.2% | [-25.2%, -0.1%] | 177 |
95+
| All ❌✅ (primary) | -2.1% | [-10.6%, 13.7%] | 115 |
96+
- Huge wins outweigh the small losses.
97+
98+
99+
Rollup of 6 pull requests [#117769](https://github.com/rust-lang/rust/pull/117769) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0f44eb32f1123ac93ab404d74c295263ce468343&end=d42d73b144fbb6ccc9684b197a3b6ed53592d09b&stat=instructions:u)
100+
101+
| (instructions:u) | mean | range | count |
102+
|:----------------------------------:|:-----:|:---------------:|:-----:|
103+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 1 |
104+
| Regressions ❌ <br /> (secondary) | 1.0% | [1.0%, 1.0%] | 1 |
105+
| Improvements ✅ <br /> (primary) | -6.5% | [-12.3%, -0.7%] | 2 |
106+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
107+
| All ❌✅ (primary) | -4.2% | [-12.3%, 0.3%] | 3 |
108+
- Noise
109+

0 commit comments

Comments
 (0)