Review batch

Author: Kobzol

collector/benchmarks/README.md

@@ -20,7 +20,7 @@ They mostly consist of real-world crates.
   programs.
 - **cranelift-codegen**: The largest crate from a code generator. Used by
   Firefox.
-- **diesel**: A type save SQL query builder. Utilizes the type system to
+- **diesel**: A type safe SQL query builder. Utilizes the type system to
   ensure a lot of invariants. Stresses anything related to resolving
   trait bounds, by having a lot of trait impls for a large number of different
   types.

collector/src/execute.rs

@@ -112,7 +112,7 @@ fn default_runs() -> usize {
 
 #[derive(Debug, Clone, serde::Deserialize)]
 #[serde(rename_all = "lowercase")]
-enum Category {
+pub enum Category {
     Primary,
     Secondary,
 }

collector/src/main.rs

@@ -15,6 +15,7 @@ use tokio::runtime::Runtime;
 mod execute;
 mod sysroot;
 
+use crate::execute::Category;
 use execute::{BenchProcessor, Benchmark, BenchmarkName, ProfileProcessor, Profiler};
 use sysroot::Sysroot;
 
@@ -255,7 +256,7 @@ fn bench(
         measure_and_record(
             &BenchmarkName("rustc".to_string()),
             /* supports_stable */ false,
-            "primary",
+            &Category::Primary.to_string(),
             &|| eprintln!("Special benchmark commencing (due to `--bench-rustc`)"),
             &|processor| processor.measure_rustc(compiler).context("measure rustc"),
         );

site/static/compare.html

@@ -279,6 +279,12 @@
                 width: 20%;
             }
         }
+        .category-title {
+            font-weight: bold;
+            font-size: 1.2em;
+            margin: 10px;
+            text-align: center;
+        }
     </style>
     <script src="https://cdn.jsdelivr.net/npm/vue@2/dist/vue.js"></script>
 </head>
@@ -632,8 +638,8 @@ <h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{
             },
             template: `
 <div class="bench-table">
-<div>{{ title }} benchmarks</div>
-<div v-if="cases.length === 0">
+<div class="category-title">{{ title }} benchmarks</div>
+<div v-if="cases.length === 0" style="text-align: center;">
   No results
 </div>
 <table v-else class="benches compare">