Skip to content

Commit f4583af

Browse files
committed
Change wording in perf summary PR comment to expose the used aggregation statistic
1 parent 0a79db2 commit f4583af

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

site/src/comparison.rs

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,11 @@ impl ComparisonSummary {
299299
self.average(self.improvements())
300300
}
301301

302+
/// The average change as a percent
303+
pub fn average_change(&self) -> f64 {
304+
self.average(&self.comparisons)
305+
}
306+
302307
/// The average regression as a percent
303308
pub fn average_regression(&self) -> f64 {
304309
self.average(self.regressions())
@@ -376,19 +381,27 @@ impl ComparisonSummary {
376381
if self.num_regressions > 1 {
377382
writeln!(
378383
result,
379-
"- Average relevant regression: {:.1}%",
384+
"- Arithmetic mean of relevant regressions: {:.1}%",
380385
self.average_regression()
381386
)
382387
.unwrap();
383388
}
384389
if self.num_improvements > 1 {
385390
writeln!(
386391
result,
387-
"- Average relevant improvement: {:.1}%",
392+
"- Arithmetic mean of relevant improvements: {:.1}%",
388393
self.average_improvement()
389394
)
390395
.unwrap();
391396
}
397+
if self.num_improvements > 1 && self.num_regressions > 1 {
398+
writeln!(
399+
result,
400+
"- Arithmetic mean of relevant changes: {:.1}%",
401+
self.average_change()
402+
)
403+
.unwrap();
404+
}
392405
for change in self.most_relevant_changes().iter().filter_map(|s| *s) {
393406
write!(result, "- ").unwrap();
394407
change.summary_line(result, link)

0 commit comments

Comments
 (0)