Skip to content

Commit f7ebcf6

Browse files
authored
Merge pull request #1754 from Kobzol/remove-speedscope
Remove speedscope link from detailed query page
2 parents ae803c6 + 1aa5500 commit f7ebcf6

File tree

1 file changed

+4
-22
lines changed

1 file changed

+4
-22
lines changed

site/frontend/src/pages/detailed-query.ts

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,6 @@ function populate_data(data, state: Selector) {
7171
window.location.origin + processed_url(commit, bench, run, "crox");
7272
return encodeURIComponent(crox_url);
7373
};
74-
let speedscope_link = (commit, bench, run) => {
75-
let benchmark_name = `${bench} run ${run}`;
76-
let crox_url = processed_crox_url(commit, bench, run);
77-
let speedscope_url = `https://www.speedscope.app/#profileURL=${crox_url}&title=${encodeURIComponent(
78-
benchmark_name
79-
)}`;
80-
return `<a href="${speedscope_url}">speedscope.app</a>`;
81-
};
8274
let firefox_profiler_link = (commit, bench, run) => {
8375
let crox_url = processed_crox_url(commit, bench, run);
8476
let ff_url = `https://profiler.firefox.com/from-url/${crox_url}/marker-chart/?v=5`;
@@ -99,16 +91,11 @@ function populate_data(data, state: Selector) {
9991
state,
10092
"codegen-schedule"
10193
)}
102-
(${speedscope_link(
94+
(${firefox_profiler_link(
10395
state.base_commit,
10496
state.benchmark,
10597
state.scenario
106-
)},
107-
${firefox_profiler_link(
108-
state.base_commit,
109-
state.benchmark,
110-
state.scenario
111-
)})
98+
)})
11299
results for ${state.base_commit.substring(
113100
0,
114101
10
@@ -120,16 +107,11 @@ function populate_data(data, state: Selector) {
120107
${processed_link(state.commit, state, "flamegraph")},
121108
${processed_link(state.commit, state, "crox")},
122109
${processed_link(state.commit, state, "codegen-schedule")}
123-
(${speedscope_link(
110+
(${firefox_profiler_link(
124111
state.commit,
125112
state.benchmark,
126113
state.scenario
127-
)},
128-
${firefox_profiler_link(
129-
state.commit,
130-
state.benchmark,
131-
state.scenario
132-
)})
114+
)})
133115
results for ${state.commit.substring(0, 10)} (new commit)`;
134116
// TODO: use the Cachegrind Vue components once this page is refactored to Vue
135117
let profile = (b) =>

0 commit comments

Comments
 (0)