Skip to content

Commit ffe4171

Browse files
committed
Add titles to benchmark detail sections
1 parent b868080 commit ffe4171

File tree

1 file changed

+67
-46
lines changed

1 file changed

+67
-46
lines changed

site/frontend/src/pages/compare/compile/table/benchmark-detail.vue

Lines changed: 67 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -61,60 +61,81 @@ onMounted(() => renderGraph());
6161

6262
<template>
6363
<div class="wrapper">
64-
<table>
65-
<tbody>
66-
<tr>
67-
<td>Benchmark</td>
68-
<td>{{ testCase.benchmark }}</td>
69-
</tr>
70-
<tr>
71-
<td>Profile</td>
72-
<td>{{ testCase.profile }}</td>
73-
</tr>
74-
<tr>
75-
<td>Scenario</td>
76-
<td>{{ testCase.scenario }}</td>
77-
</tr>
78-
<tr>
79-
<td>Category</td>
80-
<td>{{ testCase.category }}</td>
81-
</tr>
82-
<tr v-if="(metadata?.binary ?? null) !== null">
83-
<td>Artifact</td>
84-
<td>{{ metadata.binary ? "binary" : "library" }}</td>
85-
</tr>
86-
<tr v-if="(metadata?.iterations ?? null) !== null">
87-
<td>
88-
Iterations<Tooltip>
89-
How many times is the benchmark executed?
90-
</Tooltip>
91-
</td>
92-
<td>{{ metadata.iterations }}</td>
93-
</tr>
94-
<tr v-if="(cargoProfile?.lto ?? null) !== null">
95-
<td>LTO</td>
96-
<td>{{ cargoProfile.lto }}</td>
97-
</tr>
98-
<tr v-if="(cargoProfile?.debug ?? null) !== null">
99-
<td>Debuginfo</td>
100-
<td>{{ cargoProfile.debug }}</td>
101-
</tr>
102-
<tr v-if="(cargoProfile?.codegen_units ?? null) !== null">
103-
<td>Codegen units</td>
104-
<td>{{ cargoProfile.codegen_units }}</td>
105-
</tr>
106-
</tbody>
107-
</table>
108-
<div ref="chartElement"></div>
64+
<div>
65+
<div class="title info bold">Benchmark info</div>
66+
<table>
67+
<tbody>
68+
<tr>
69+
<td>Benchmark</td>
70+
<td>{{ testCase.benchmark }}</td>
71+
</tr>
72+
<tr>
73+
<td>Profile</td>
74+
<td>{{ testCase.profile }}</td>
75+
</tr>
76+
<tr>
77+
<td>Scenario</td>
78+
<td>{{ testCase.scenario }}</td>
79+
</tr>
80+
<tr>
81+
<td>Category</td>
82+
<td>{{ testCase.category }}</td>
83+
</tr>
84+
<tr v-if="(metadata?.binary ?? null) !== null">
85+
<td>Artifact</td>
86+
<td>{{ metadata.binary ? "binary" : "library" }}</td>
87+
</tr>
88+
<tr v-if="(metadata?.iterations ?? null) !== null">
89+
<td>
90+
Iterations<Tooltip>
91+
How many times is the benchmark executed?
92+
</Tooltip>
93+
</td>
94+
<td>{{ metadata.iterations }}</td>
95+
</tr>
96+
<tr v-if="(cargoProfile?.lto ?? null) !== null">
97+
<td>LTO</td>
98+
<td>{{ cargoProfile.lto }}</td>
99+
</tr>
100+
<tr v-if="(cargoProfile?.debug ?? null) !== null">
101+
<td>Debuginfo</td>
102+
<td>{{ cargoProfile.debug }}</td>
103+
</tr>
104+
<tr v-if="(cargoProfile?.codegen_units ?? null) !== null">
105+
<td>Codegen units</td>
106+
<td>{{ cargoProfile.codegen_units }}</td>
107+
</tr>
108+
</tbody>
109+
</table>
110+
</div>
111+
<div>
112+
<div class="title">
113+
<div class="bold">30 day history (up to benchmarked commit)</div>
114+
<div style="font-size: 0.8em">
115+
Each plotted value is relative to its previous commit
116+
</div>
117+
</div>
118+
<div ref="chartElement"></div>
119+
</div>
109120
</div>
110121
</template>
111122

112123
<style scoped lang="scss">
113124
.wrapper {
114125
display: flex;
126+
margin: 10px 0;
127+
}
128+
.title {
129+
&.bold,
130+
.bold {
131+
font-weight: bold;
132+
}
133+
&.info {
134+
margin-bottom: 15px;
135+
}
115136
}
116137
table {
117-
align-self: center;
138+
align-self: flex-start;
118139
margin-right: 20px;
119140
120141
td {

0 commit comments

Comments
 (0)