Skip to content

Compare page tweaks #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Compare page tweaks #1474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d0d570
Add a quick link for Wall time.
nnethercote Oct 19, 2022
b0cc4a2
Move "Do another comparison" down.
nnethercote Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 30 additions & 29 deletions site/static/compare.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,34 @@
</div>
<br />
<div id="app">
<h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{{before}}</span> and
<span id="after">{{after}}</span>
</h2>
<div v-if="data" style="margin: 12px 0;">
<div style="display: flex;justify-content: center;">
<div class="description-box">
<div v-if="data.prev" class="description-arrow"><a v-bind:href="prevLink">&larr;</a></div>
<div style="padding: 10px;">
<span><a v-if="data.a.pr" v-bind:href="prLink(data.a.pr)">#{{data.a.pr}}</a>&nbsp;</span>
<span v-if="data.a.date">{{formatDate(data.a.date)}}</span>
(<a v-bind:href="commitLink(data.a.commit)">{{short(data.a)}}</a>)
</div>
</div>
<div v-if="notContinuous" id="not-continuous" title="WARNING! The commits are not continuous.">...
</div>
<div class="description-box">
<div style="padding: 10px;">
<span><a v-if="data.b.pr" v-bind:href="prLink(data.b.pr)">#{{data.b.pr}}</a>&nbsp;</span>
<span v-if="data.b.date">{{formatDate(data.b.date)}}</span>
(<a v-bind:href="commitLink(data.b.commit)">{{short(data.b)}}</a>)
</div>
<div v-if="data.next" class="description-arrow"><a v-bind:href="nextLink">&rarr;</a></div>
</div>
</div>
<div style="display: flex; justify-content: center;">
<a v-bind:href="compareLink">🔎 compare commits</a>
</div>
</div>
<fieldset id="settings">
<legend id="search-toggle" class="section-heading">Do another comparison<span
class="toggle-indicator" id="search-toggle-indicator"></span></legend>
Expand Down Expand Up @@ -50,40 +78,13 @@
<div v-for="metric in [
['Instructions', 'instructions:u', 'Number of executed instructions'],
['Cycles', 'cycles:u', 'Number of executed cycles'],
['Max RSS', 'max-rss', 'Highest amount of total allocated memory during the course of the compilation'],
['Wall time', 'wall-time', 'Wall time'],
['Max RSS', 'max-rss', 'Peak memory usage (resident set size)'],
['Binary size', 'size:linked_artifact', 'Size of the generated binary artifact']
]" :class="{ active: stat === metric[1] }" :title="metric[2]">
<a :href="createUrlForMetric(metric[1])">{{ metric[0] }}</a>
</div>
</div>
<h2>Comparing <span id="stat-header">{{stat}}</span> between <span id="before">{{before}}</span> and
<span id="after">{{after}}</span>
</h2>
<div v-if="data" style="margin: 12px 0;">
<div style="display: flex;justify-content: center;">
<div class="description-box">
<div v-if="data.prev" class="description-arrow"><a v-bind:href="prevLink">&larr;</a></div>
<div style="padding: 10px;">
<span><a v-if="data.a.pr" v-bind:href="prLink(data.a.pr)">#{{data.a.pr}}</a>&nbsp;</span>
<span v-if="data.a.date">{{formatDate(data.a.date)}}</span>
(<a v-bind:href="commitLink(data.a.commit)">{{short(data.a)}}</a>)
</div>
</div>
<div v-if="notContinuous" id="not-continuous" title="WARNING! The commits are not continuous.">...
</div>
<div class="description-box">
<div style="padding: 10px;">
<span><a v-if="data.b.pr" v-bind:href="prLink(data.b.pr)">#{{data.b.pr}}</a>&nbsp;</span>
<span v-if="data.b.date">{{formatDate(data.b.date)}}</span>
(<a v-bind:href="commitLink(data.b.commit)">{{short(data.b)}}</a>)
</div>
<div v-if="data.next" class="description-arrow"><a v-bind:href="nextLink">&rarr;</a></div>
</div>
</div>
<div style="display: flex; justify-content: center;">
<a v-bind:href="compareLink">🔎 compare commits</a>
</div>
</div>
<fieldset id="filters" class="collapsible-section">
<legend id="filters-toggle" class="section-heading">Filters<span class="toggle-indicator" id="filters-toggle-indicator"></span>
</legend>
Expand Down