Skip to content

Commit 580d6e9

Browse files
refactor: apply more parser and a TyAlias change
1 parent 4a00fa8 commit 580d6e9

File tree

5 files changed

+29
-14
lines changed

5 files changed

+29
-14
lines changed

rustfmt-core/rustfmt-lib/src/formatting.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ fn format_project<T: FormatHandler>(
9393
let mut context = FormatContext::new(&krate, report, parse_session, config, handler);
9494
let files = modules::ModResolver::new(
9595
&context.parse_session,
96-
directory_ownership.unwrap_or(DirectoryOwnership::UnownedViaMod(true)),
96+
directory_ownership.unwrap_or(DirectoryOwnership::UnownedViaMod),
9797
!input_is_stdin && config.recursive(),
9898
)
9999
.visit_crate(&krate)

rustfmt-core/rustfmt-lib/src/macros.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1476,7 +1476,7 @@ fn format_lazy_static(
14761476

14771477
while parser.token.kind != TokenKind::Eof {
14781478
// Parse a `lazy_static!` item.
1479-
let vis = crate::utils::format_visibility(context, &parse_or!(parse_visibility, false));
1479+
let vis = crate::utils::format_visibility(context, &parse_or!(parse_visibility, rustc_parse::parser::FollowedByType::No));
14801480
parser.eat_keyword(kw::Static);
14811481
parser.eat_keyword(kw::Ref);
14821482
let id = parse_or!(parse_ident);

rustfmt-core/rustfmt-lib/src/modules.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ impl<'ast, 'sess, 'c> ModResolver<'ast, 'sess> {
252252

253253
let relative = match self.directory.ownership {
254254
DirectoryOwnership::Owned { relative } => relative,
255-
DirectoryOwnership::UnownedViaBlock | DirectoryOwnership::UnownedViaMod(_) => None,
255+
DirectoryOwnership::UnownedViaBlock | DirectoryOwnership::UnownedViaMod => None,
256256
};
257257
match self
258258
.parse_sess

rustfmt-core/rustfmt-lib/src/syntux/session.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use std::cell::RefCell;
22
use std::path::Path;
33
use std::rc::Rc;
44

5-
use rustc_data_structures::sync::Send;
5+
use rustc_data_structures::sync::{Lrc, Send};
66
use rustc_errors::emitter::{Emitter, EmitterWriter};
77
use rustc_errors::{ColorConfig, Diagnostic, Handler, Level as DiagnosticLevel};
88
use rustc_span::{BytePos, source_map::{FilePathMapping, SourceMap}, Span};
@@ -27,6 +27,7 @@ pub(crate) struct ParseSess {
2727
struct SilentEmitter;
2828

2929
impl Emitter for SilentEmitter {
30+
fn source_map(&self) -> Option<&Lrc<SourceMap>> { None }
3031
fn emit_diagnostic(&mut self, _db: &Diagnostic) {}
3132
}
3233

@@ -52,6 +53,7 @@ impl SilentOnIgnoredFilesEmitter {
5253
}
5354

5455
impl Emitter for SilentOnIgnoredFilesEmitter {
56+
fn source_map(&self) -> Option<&Lrc<SourceMap>> { None }
5557
fn emit_diagnostic(&mut self, db: &Diagnostic) {
5658
if db.level == DiagnosticLevel::Fatal {
5759
return self.handle_non_ignoreable_error(db);

rustfmt-core/rustfmt-lib/src/visitor.rs

Lines changed: 23 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -524,16 +524,29 @@ impl<'b, 'a: 'b> FmtVisitor<'a> {
524524
);
525525
self.push_rewrite(item.span, rewrite);
526526
}
527-
ast::ItemKind::OpaqueTy(ref generic_bounds, ref generics) => {
528-
let rewrite = rewrite_opaque_type(
529-
&self.get_context(),
530-
self.block_indent,
531-
item.ident,
532-
generic_bounds,
533-
generics,
534-
&item.vis,
535-
);
536-
self.push_rewrite(item.span, rewrite);
527+
ast::ItemKind::TyAlias(ref ty, ref generics) => match ty.kind.opaque_top_hack() {
528+
None => {
529+
let rewrite = rewrite_type_alias(
530+
&self.get_context(),
531+
self.block_indent,
532+
item.ident,
533+
ty,
534+
generics,
535+
&item.vis,
536+
);
537+
self.push_rewrite(item.span, rewrite);
538+
},
539+
Some(generic_bounds) => {
540+
let rewrite = rewrite_opaque_type(
541+
&self.get_context(),
542+
self.block_indent,
543+
item.ident,
544+
generic_bounds,
545+
generics,
546+
&item.vis,
547+
);
548+
self.push_rewrite(item.span, rewrite);
549+
}
537550
}
538551
ast::ItemKind::GlobalAsm(..) => {
539552
let snippet = Some(self.snippet(item.span).to_owned());

0 commit comments

Comments
 (0)