Skip to content

Commit 6d7a764

Browse files
committed
Remove span from rewrite_generics's parameter
We can just use the span from ast::Generics.
1 parent fc307ff commit 6d7a764

File tree

1 file changed

+8
-22
lines changed

1 file changed

+8
-22
lines changed

src/items.rs

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -801,17 +801,12 @@ fn format_impl_ref_and_type(
801801
result.push_str(format_defaultness(defaultness));
802802
result.push_str(format_unsafety(unsafety));
803803

804-
let lo = context.snippet_provider.span_after(item.span, "impl");
805-
let hi = match *trait_ref {
806-
Some(ref tr) => tr.path.span.lo(),
807-
None => self_ty.span.lo(),
808-
};
809804
let shape = generics_shape_from_config(
810805
context.config,
811806
Shape::indented(offset + last_line_width(&result), context.config),
812807
0,
813808
)?;
814-
let generics_str = rewrite_generics(context, "impl", generics, shape, mk_sp(lo, hi))?;
809+
let generics_str = rewrite_generics(context, "impl", generics, shape)?;
815810
result.push_str(&generics_str);
816811

817812
let polarity_str = if polarity == ast::ImplPolarity::Negative {
@@ -986,13 +981,8 @@ pub fn format_trait(context: &RewriteContext, item: &ast::Item, offset: Indent)
986981
let body_lo = context.snippet_provider.span_after(item.span, "{");
987982

988983
let shape = Shape::indented(offset, context.config).offset_left(result.len())?;
989-
let generics_str = rewrite_generics(
990-
context,
991-
rewrite_ident(context, item.ident),
992-
generics,
993-
shape,
994-
mk_sp(item.span.lo(), body_lo),
995-
)?;
984+
let generics_str =
985+
rewrite_generics(context, rewrite_ident(context, item.ident), generics, shape)?;
996986
result.push_str(&generics_str);
997987

998988
// FIXME(#2055): rustfmt fails to format when there are comments between trait bounds.
@@ -1138,7 +1128,7 @@ pub fn format_trait_alias(
11381128
let alias = rewrite_ident(context, ident);
11391129
// 6 = "trait ", 2 = " ="
11401130
let g_shape = shape.offset_left(6)?.sub_width(2)?;
1141-
let generics_str = rewrite_generics(context, &alias, generics, g_shape, generics.span)?;
1131+
let generics_str = rewrite_generics(context, &alias, generics, g_shape)?;
11421132
let lhs = format!("trait {} =", generics_str);
11431133
// 1 = ";"
11441134
rewrite_assign_rhs(context, lhs, generic_bounds, shape.sub_width(1)?).map(|s| s + ";")
@@ -1340,8 +1330,7 @@ fn format_tuple_struct(
13401330
Some(generics) => {
13411331
let budget = context.budget(last_line_width(&header_str));
13421332
let shape = Shape::legacy(budget, offset);
1343-
let g_span = mk_sp(span.lo(), body_lo);
1344-
let generics_str = rewrite_generics(context, "", generics, shape, g_span)?;
1333+
let generics_str = rewrite_generics(context, "", generics, shape)?;
13451334
result.push_str(&generics_str);
13461335

13471336
let where_budget = context.budget(last_line_width(&result));
@@ -1418,7 +1407,7 @@ fn rewrite_type_prefix(
14181407
let g_shape = Shape::indented(indent, context.config)
14191408
.offset_left(result.len())?
14201409
.sub_width(2)?;
1421-
let generics_str = rewrite_generics(context, ident_str, generics, g_shape, generics.span)?;
1410+
let generics_str = rewrite_generics(context, ident_str, generics, g_shape)?;
14221411
result.push_str(&generics_str);
14231412
}
14241413

@@ -1942,13 +1931,11 @@ fn rewrite_fn_base(
19421931
offset: used_width,
19431932
};
19441933
let fd = fn_sig.decl;
1945-
let g_span = mk_sp(span.lo(), fd.output.span().lo());
19461934
let generics_str = rewrite_generics(
19471935
context,
19481936
rewrite_ident(context, ident),
19491937
fn_sig.generics,
19501938
shape,
1951-
g_span,
19521939
)?;
19531940
result.push_str(&generics_str);
19541941

@@ -2466,7 +2453,6 @@ fn rewrite_generics(
24662453
ident: &str,
24672454
generics: &ast::Generics,
24682455
shape: Shape,
2469-
span: Span,
24702456
) -> Option<String> {
24712457
// FIXME: convert bounds to where clauses where they get too big or if
24722458
// there is a where clause at all.
@@ -2476,7 +2462,7 @@ fn rewrite_generics(
24762462
}
24772463

24782464
let params = &generics.params.iter().map(|e| &*e).collect::<Vec<_>>();
2479-
overflow::rewrite_with_angle_brackets(context, ident, params, shape, span)
2465+
overflow::rewrite_with_angle_brackets(context, ident, params, shape, generics.span)
24802466
}
24812467

24822468
pub fn generics_shape_from_config(config: &Config, shape: Shape, offset: usize) -> Option<Shape> {
@@ -2764,7 +2750,7 @@ fn format_generics(
27642750
used_width: usize,
27652751
) -> Option<String> {
27662752
let shape = Shape::legacy(context.budget(used_width + offset.width()), offset);
2767-
let mut result = rewrite_generics(context, "", generics, shape, span)?;
2753+
let mut result = rewrite_generics(context, "", generics, shape)?;
27682754

27692755
let same_line_brace = if !generics.where_clause.predicates.is_empty() || result.contains('\n') {
27702756
let budget = context.budget(last_line_used_width(&result, offset.width()));

0 commit comments

Comments
 (0)