Skip to content

Commit d1f5486

Browse files
authored
add performance triage report for this week
1 parent 085c1d2 commit d1f5486

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

draft/2021-11-24-this-week-in-rust.md

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -97,25 +97,18 @@ If you are a Rust project owner and are looking for contributors, please submit
9797

9898
### Rust Compiler Performance Triage
9999

100-
A large amount of noise in the comparisons this week, likely due to new
101-
probabilistic query hash verification increasing likelihood of changes in each
102-
benchmark; solutions are being tracked in [rustc-perf#1105].
103100

104-
Otherwise, though, the week largely amounted to a neutral one for performance.
105-
There were some regressions, particularly in doc builds, as a result of the
106-
addition of portable SIMD. These are relatively speaking minor and primarily
107-
impact small crates.
101+
This week, there were a number of cases where the `incr-unchanged` variants of `inflate` went up or down by 5% to 6%; we believe these are instances of increased noise in benchmarks documented on [rustc-perf#1105](https://github.com/rust-lang/rustc-perf/issues/1105). I was tempted to remove these from the report, but its non-trivial to re-construct the report "as if" some benchmark were omitted.
108102

109-
[rustc-perf#1105]: https://github.com/rust-lang/rustc-perf/issues/1105
103+
Otherwise, there were some nice wins for performance. For example, PR [#90996](https://github.com/rust-lang/rust/issues/90996) more than halved the compilation time for `full` builds of `diesel` by revising how we hash `ObligationCauseData`. If anyone is interested, it might be good to follow-up on the effects of PR [#90352](https://github.com/rust-lang/rust/issues/90352), "Simplify `for` loop desugar", where we have hypothesized that the increased compilation time is due to more LLVM optimizations being applied.
110104

111-
Triage done by **@simulacrum**.
112-
Revision range: [eee8b9c7..934624f](https://perf.rust-lang.org/?start=eee8b9c7bafade55981d155dae71657f1cc55a22&end=934624fe5f66ce3fb8abf0597a6deb079783335f&absolute=false&stat=instructions%3Au)
105+
Triage done by **@pnkfelix**.
106+
Revision range: [934624fe..22c2d9dd](https://perf.rust-lang.org/?start=934624fe5f66ce3fb8abf0597a6deb079783335f&end=22c2d9ddbf356bcdb718e88ca6ee3665e1e42690&absolute=false&stat=instructions%3Au)
113107

114-
5 Regressions, 2 Improvements, 6 Mixed; 2 of them in rollups
108+
1 Regressions, 3 Improvements, 8 Mixed; 3 of them in rollups
109+
34 comparisons made in total
115110

116-
41 comparisons made in total
117-
118-
[Full report here](https://github.com/rust-lang/rustc-perf/blob/master/triage/2021-11-16.md)
111+
[Full report here](https://github.com/rust-lang/rustc-perf/blob/master/triage/2021-11-23.md)
119112

120113
### Approved RFCs
121114

0 commit comments

Comments
 (0)