-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add link to Why Not Inheritance #2902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a link to a blog talking about why Rust does not have inheritance like other OO languages do.
I don't think the text after the link is part of the TWiR style; I'd suggest removing that. |
Can @Folyd or @MATRIXKOO review this? |
It's just a little pitch. My intention is to give a brief before people consider reading it. If it's not appropriate, I'm fine with removing it. |
Hi @ifsheldon, thanks for your PR. Just my two cents:
For example, this sentence "所以终极的原因还是代 cheng 码 xu 可 yuan 复 tou 用 lan" brings no benefits to audiences except distractions. Personally, I don't think it is a good style for a technical article.
For example, I'll recommend mentioning the Do you mind changing the writing styles and supplementing more detail about Rust's inheritance? That could be better for the audience. Thanks. However, I also recommend Rust Chinese Magazine, which is a better place to meet your Chinese audiences. Feel free to contribute to that. Here is the repo: https://github.com/RustMagazine/rust_magazine_2022 |
Why so serious? Articles can be fun and at the meantime rigorous. But yeah I agree that this line is not necessary, so I changed it.
I don't think this article is not deep enough. |
Thank you @ifsheldon, @Folyd, and @ericseppanen! |
Add a link to a blog talking about why Rust does not have inheritance like other OO languages do.