Skip to content

Revert "add search" removal, fixing email publishing #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2023
Merged

Revert "add search" removal, fixing email publishing #4076

merged 3 commits into from
Feb 21, 2023

Conversation

andrewpollack
Copy link
Member

@andrewpollack andrewpollack commented Feb 20, 2023 •
edited
Loading

Reverting #4075 revert.
Restores @ndd7xv 's fantastic search PR #3942, and patches with #4077 to address reason of revert.

  • Only use search plugins for website styling, removing from email styling
  • Adds new variable TESTING_LOCALLY to ease URL adjustments
  • Renames TWIR_NEWSLETTER_THEME variable to USE_EMAIL_THEME to reflect usage in config

@andrewpollack andrewpollack changed the title Revert "Revert "add search"" Revert "add search" removal, fixing email publishing Feb 20, 2023
This was referenced Feb 20, 2023
Merged
Merged
@ndd7xv
Copy link
Contributor

ndd7xv commented Feb 21, 2023

Small nitpick, but TWIR_NEWSLETTER_THEME is still referenced in the README under to build the newsletter!

Updating this to USE_EMAIL_THEME might be helpful for people who may want to make changes to the newsletter (or people who want to check if their PRs break the newsletter because they previously made PRs that had to be reverted oop)

nellshamrell
nellshamrell approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@nellshamrell nellshamrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent! Feel free to merge, then deploy changes to the github pages site when you are ready!

@andrewpollack andrewpollack merged commit dc127f1 into master Feb 21, 2023
@andrewpollack andrewpollack deleted the revert-4075-revert-3942-search branch February 21, 2023 15:32
@andrewpollack
Copy link
Member Author

Small nitpick, but TWIR_NEWSLETTER_THEME is still referenced in the README under to build the newsletter!

Good spot @ndd7xv ! There are a few things I want to update to make the publishing workflow easier to follow, and I'll create a quick PR for this

@andrewpollack
Copy link
Member Author

#4083 captures the updated instructions for building the newsletter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nellshamrell nellshamrell nellshamrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewpollack @ndd7xv @nellshamrell