Skip to content

Replace localization strings for the Learning WG #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2020
Merged

Replace localization strings for the Learning WG #1053

merged 3 commits into from
Apr 12, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Closes #1052

@LeSeulArtichaut
Copy link
Contributor Author

@pietroalbini Got one more rename for you 😄

@Manishearth
Copy link
Member

you should rename these strings in all the other localizations too

@LeSeulArtichaut
Copy link
Contributor Author

LeSeulArtichaut commented Apr 10, 2020 •
edited
Loading

you should rename these strings in all the other localizations too

May be a good idea 🙄

@LeSeulArtichaut
Copy link
Contributor Author

@Manishearth Is there a way to reset a particular string for a language? Do I just remove everything after the = sign?

@Manishearth
Copy link
Member

Delete the entry. But do we really need to do that? It seems like the string will still be applicable

@Manishearth
Copy link
Member

Oh, for the WG name. Yeah just delete the entry

@LeSeulArtichaut
Copy link
Contributor Author

Rebased to resolve conflicts. This should now be ready to merge.

@XAMPPRocky
Copy link
Member

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit ad7ebc8 into rust-lang:master Apr 12, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the patch-1 branch April 13, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a localization string for the rustc-dev-guide WG
3 participants
@LeSeulArtichaut @Manishearth @XAMPPRocky