Use the theme a11y-dark for code blocks #1841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Jul 14, 2023
| @@ -0,0 +1,98 @@ | |||
| /*! | |||
There was a problem hiding this comment.
issue: please add a license header
(saying it is under the MIT license, linking to the source, and linking to the full text of the MIT license, should be fine)
There was a problem hiding this comment.
I guess the license is BSD-3-Clause?
https://github.com/highlightjs/highlight.js/blob/main/LICENSE
There was a problem hiding this comment.
Unless other licenses apply to the themes and I missed it.
Manishearth
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
ah, https://github.com/ericwbailey/a11y-syntax-highlighting is under MIT but if you copied it from there I suppose BSD is appropriate. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1840