Update youtube icon, fix 413 #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should not have a silid background color, according to other icons? |
|
It should indeed and it used to, I think the online svg optimizer I used to minimize the svg changed this. |
meven
force-pushed
the
update-youtube-fix-413
branch
from
440c20a to
56b4195
Compare
|
I have updated it using inkscape optimized svg output. |
|
Now, when you change the footer background color you get the expected output : Thanks @liigo for the feedback ! |
meven
force-pushed
the
update-youtube-fix-413
branch
from
56b4195 to
fd07ce8
Compare
meven
force-pushed
the
update-youtube-fix-413
branch
from
fd07ce8 to
c8ebdd5
Compare
|
Padding was incorrect, I updated the commit : |
chriskrycho
approved these changes
Dec 4, 2018
|
Nice improvement! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
Fix #413
Reduces file size of youtube.svg from 3.13 KB to 1.16 KB