Skip to content

Add relevant titles to pages #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add relevant titles to pages #531

wants to merge 2 commits into from

Conversation

meven
Copy link
Contributor

@meven meven commented Dec 3, 2018

Fixes #330
I would welcome feedback if any.

It adds better title (as in the <title>) to pages.

Site path page title
/ Rust programming language
/lean Learn - Rust programming language
/learn/get-started Get started - Rust programming language
/what/cli Cli - Rust programming language
/what/wasm Wasm - Rust programming language
/what/networking Networking - Rust programming language
/what/embedded Embedded - Rust programming language
/tools Tools - Rust programming language
/community Community - Rust programming language
/governance Governance - Rust programming language
/governance/teams/moderation Moderation team - Rust programming language
/governance/teams/crates-io Crates.io team - Rust programming language
/governance/wgs/wasm Wasm team - Rust programming language
/policies/code-of-conduct Code of conduct - Rust programming language
/policies/licenses Licenses - Rust programming language
/production Production - Rust programming language
/production/users Users - Rust programming language

I did not follow exactly #330 (comment)

I followed a pattern similar to the Rust book for instance https://doc.rust-lang.org/book/2018-edition/ch03-03-how-functions-work.html
In the browser tab we see the relevant part even when the tab has a narrow width but we still keep some context.

Capitalization could need a change, or a "The" before "Rust programming language" could be relevant.

I would welcome any feedback ;)

@meven
Copy link
Contributor Author

meven commented Dec 4, 2018

Rust 2018 is already two days away ! 😀
I would love to fix the issue at hand that.

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take is that this is good enough for the moment! We might want to use titlecase in a follow-on update, but at a minimum this gets us some good page titles for SEO and at-a-glance, which we need for the Edition release.

@meven meven deleted the fix-330 branch December 5, 2018 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants