Move over to handlebars-fluent #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
hbs-fluent
branch
from
21e5ee4 to
ddddea7
Compare
Manishearth
force-pushed
the
hbs-fluent
branch
from
ddddea7 to
e5d4d79
Compare
Manishearth
force-pushed
the
hbs-fluent
branch
from
e5d4d79 to
b00366f
Compare
pietroalbini
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946
Based on #958
We still need our own helper for
{{team-text}}, but the stuff in handlebars-fluent makes our simpler.We lose Pontoon in-context support, but it wasn't really working anyway.
r? @skade