Skip to content

Add support for the Simple Network Protocol #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GabrielMajeri opened this issue May 16, 2022 · 6 comments · Fixed by #606
Closed

Add support for the Simple Network Protocol #431

GabrielMajeri opened this issue May 16, 2022 · 6 comments · Fixed by #606

Comments

@GabrielMajeri
Copy link
Collaborator

GabrielMajeri commented May 16, 2022

This issue tracks the crate's support for the UEFI Simple Network Protocol.

There was a PR for implementing this protocol, but it was closed without getting finalized.

@d-sonuga
Copy link
Contributor

Hello. I'm new here and I would like to add the SNP Protocol. Do I just get started immediately or are there some things I have to do first?

@nicholasbishop
Copy link
Member

Hi, and welcome :) You can feel free to jump right in. There is a prior PR (linked above) that you can use as a base if you want, but feel free to proceed however your like. Please also feel free to ask any questions you might have.

@d-sonuga
Copy link
Contributor

Thanks. I'll just get started then.

@d-sonuga
Copy link
Contributor

Hi. I made quite some progress with the basic wrapper for the SNP but I'm really stumped on the test right now. The receive buffers just never receive. Any suggestions for dealing with this kind of thing?

@nicholasbishop
Copy link
Member

Want to post a draft PR with what you have? I'd be happy to take a look at that and see if I can spot anything. It's hard to make a specific suggestion otherwise, since there are just so many different things that can go wrong.

@d-sonuga
Copy link
Contributor

d-sonuga commented Oct 31, 2022

I've posted a draft PR here: #541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants