Skip to content

Commit 47acbab

Browse files
authored
Merge pull request #837 from afdw/master
Update weedle: use special instead of specials
2 parents 866d9e2 + 61eb7df commit 47acbab

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

crates/webidl/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ proc-macro2 = "0.4.8"
2020
quote = '0.6'
2121
syn = { version = '0.15', features = ['full'] }
2222
wasm-bindgen-backend = { version = "=0.2.21", path = "../backend" }
23-
weedle = "0.7"
23+
weedle = "0.8"

crates/webidl/src/first_pass.rs

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -447,10 +447,6 @@ impl<'src> FirstPass<'src, &'src str> for weedle::interface::InterfaceMember<'sr
447447

448448
impl<'src> FirstPass<'src, &'src str> for weedle::interface::OperationInterfaceMember<'src> {
449449
fn first_pass(&'src self, record: &mut FirstPassRecord<'src>, self_name: &'src str) -> Result<()> {
450-
if self.specials.len() > 1 {
451-
warn!("Unsupported webidl operation: {:?}", self);
452-
return Ok(())
453-
}
454450
let is_static = match self.modifier {
455451
Some(StringifierOrStatic::Stringifier(_)) => {
456452
warn!("Unsupported webidl stringifier: {:?}", self);
@@ -461,13 +457,13 @@ impl<'src> FirstPass<'src, &'src str> for weedle::interface::OperationInterfaceM
461457
};
462458

463459
let mut ids = vec![OperationId::Operation(self.identifier.map(|s| s.0))];
464-
for special in self.specials.iter() {
465-
ids.push(match special {
466-
Special::Getter(_) => OperationId::IndexingGetter,
467-
Special::Setter(_) => OperationId::IndexingSetter,
468-
Special::Deleter(_) => OperationId::IndexingDeleter,
469-
Special::LegacyCaller(_) => continue,
470-
});
460+
if let Some(special) = self.special {
461+
match special {
462+
Special::Getter(_) => ids.push(OperationId::IndexingGetter),
463+
Special::Setter(_) => ids.push(OperationId::IndexingSetter),
464+
Special::Deleter(_) => ids.push(OperationId::IndexingDeleter),
465+
Special::LegacyCaller(_) => {},
466+
};
471467
}
472468
first_pass_operation(
473469
record,

0 commit comments

Comments
 (0)