Skip to content

Commit a37fa45

Browse files
authored
Merge pull request #845 from alexcrichton/more-webidl
Uncommented some WebIDL TODO
2 parents b38b9da + a02c4c1 commit a37fa45

File tree

3 files changed

+1
-23
lines changed

3 files changed

+1
-23
lines changed

crates/web-sys/webidls/enabled/Document.webidl

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ interface nsISupports;
2020
interface URI;
2121
interface nsIDocShell;
2222
interface nsILoadGroup;
23+
*/
2324

2425
enum VisibilityState { "hidden", "visible" };
25-
*/
2626

2727
/* https://dom.spec.whatwg.org/#dictdef-elementcreationoptions */
2828
dictionary ElementCreationOptions {
@@ -35,11 +35,8 @@ dictionary ElementCreationOptions {
3535
/* https://dom.spec.whatwg.org/#interface-document */
3636
[Constructor]
3737
interface Document : Node {
38-
39-
/*TODO
4038
[Throws]
4139
readonly attribute DOMImplementation implementation;
42-
*/
4340
[Pure, Throws, BinaryName="documentURIFromJS", NeedsCallerType]
4441
readonly attribute DOMString URL;
4542
[Pure, Throws, BinaryName="documentURIFromJS", NeedsCallerType]
@@ -79,10 +76,8 @@ interface Document : Node {
7976
Text createTextNode(DOMString data);
8077
[NewObject]
8178
Comment createComment(DOMString data);
82-
/*TODO
8379
[NewObject, Throws]
8480
ProcessingInstruction createProcessingInstruction(DOMString target, DOMString data);
85-
*/
8681

8782
[CEReactions, Throws]
8883
Node importNode(Node node, optional boolean deep = false);
@@ -92,10 +87,8 @@ interface Document : Node {
9287
[NewObject, Throws, NeedsCallerType]
9388
Event createEvent(DOMString interface);
9489

95-
/*TODO
9690
[NewObject, Throws]
9791
Range createRange();
98-
*/
9992

10093
// NodeFilter.SHOW_ALL = 0xFFFFFFFF
10194
[NewObject, Throws]
@@ -110,26 +103,22 @@ interface Document : Node {
110103

111104
// These are not in the spec, but leave them for now for backwards compat.
112105
// So sort of like Gecko extensions
113-
/*TODO
114106
[NewObject, Throws]
115107
CDATASection createCDATASection(DOMString data);
116108
[NewObject, Throws]
117109
Attr createAttribute(DOMString name);
118110
[NewObject, Throws]
119111
Attr createAttributeNS(DOMString? namespace, DOMString name);
120-
*/
121112
};
122113

123114
// https://html.spec.whatwg.org/multipage/dom.html#the-document-object
124115
partial interface Document {
125-
/*TODO
126116
[PutForwards=href, Unforgeable] readonly attribute Location? location;
127117
//(HTML only) attribute DOMString domain;
128118
readonly attribute DOMString referrer;
129119
//(HTML only) attribute DOMString cookie;
130120
readonly attribute DOMString lastModified;
131121
readonly attribute DOMString readyState;
132-
*/
133122

134123
// DOM tree accessors
135124
//(Not proxy yet)getter object (DOMString name);
@@ -305,11 +294,8 @@ partial interface Document {
305294
// https://w3c.github.io/page-visibility/#extensions-to-the-document-interface
306295
partial interface Document {
307296
readonly attribute boolean hidden;
308-
309-
/*TODO
310297
readonly attribute VisibilityState visibilityState;
311298
attribute EventHandler onvisibilitychange;
312-
*/
313299
};
314300

315301
// https://drafts.csswg.org/cssom/#extensions-to-the-document-interface
@@ -402,10 +388,8 @@ partial interface Document {
402388

403389
// http://w3c.github.io/selection-api/#extensions-to-document-interface
404390
partial interface Document {
405-
/*TODO
406391
[Throws]
407392
Selection? getSelection();
408-
*/
409393
};
410394

411395
// Extension to give chrome JS the ability to determine whether

crates/web-sys/webidls/enabled/Element.webidl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@ interface Element : Node {
2929
attribute DOMString id;
3030
[CEReactions, Pure]
3131
attribute DOMString className;
32-
/*TODO
3332
[Constant, PutForwards=value]
3433
readonly attribute DOMTokenList classList;
35-
*/
3634

3735
[SameObject]
3836
readonly attribute NamedNodeMap attributes;

crates/web-sys/webidls/enabled/Node.webidl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,8 @@ interface Node : EventTarget {
4040
readonly attribute boolean isConnected;
4141
[Pure]
4242
readonly attribute Document? ownerDocument;
43-
/*TODO
4443
[Pure]
4544
Node getRootNode(optional GetRootNodeOptions options);
46-
*/
4745
[Pure]
4846
readonly attribute Node? parentNode;
4947
[Pure]
@@ -103,8 +101,6 @@ interface Node : EventTarget {
103101
boolean isDefaultNamespace(DOMString? namespace);
104102
};
105103

106-
/*TODO
107104
dictionary GetRootNodeOptions {
108105
boolean composed = false;
109106
};
110-
*/

0 commit comments

Comments
 (0)