Skip to content

Fix auth registration for client credentials #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/mcp/server/auth/handlers/register.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,20 @@ async def handle(self, request: Request) -> Response:
),
status_code=400,
)
if set(client_metadata.grant_types) != {"authorization_code", "refresh_token"}:
grant_types_set = set(client_metadata.grant_types)
valid_sets = [
{"authorization_code", "refresh_token"},
{"client_credentials"},
]

if grant_types_set not in valid_sets:
return PydanticJSONResponse(
content=RegistrationErrorResponse(
error="invalid_client_metadata",
error_description="grant_types must be authorization_code "
"and refresh_token",
error_description=(
"grant_types must be authorization_code and refresh_token "
"or client_credentials"
),
),
status_code=400,
)
Expand Down
24 changes: 23 additions & 1 deletion tests/server/fastmcp/auth/test_auth_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -1001,9 +1001,31 @@ async def test_client_registration_invalid_grant_type(
assert error_data["error"] == "invalid_client_metadata"
assert (
error_data["error_description"]
== "grant_types must be authorization_code and refresh_token"
== (
"grant_types must be authorization_code and "
"refresh_token or client_credentials"
)
)

@pytest.mark.anyio
async def test_client_registration_client_credentials(
self, test_client: httpx.AsyncClient
):
client_metadata = {
"redirect_uris": ["https://client.example.com/callback"],
"client_name": "CC Client",
"grant_types": ["client_credentials"],
}

response = await test_client.post(
"/register",
json=client_metadata,
)

assert response.status_code == 201, response.content
client_info = response.json()
assert client_info["grant_types"] == ["client_credentials"]


class TestAuthorizeEndpointErrors:
"""Test error handling in the OAuth authorization endpoint."""
Expand Down