pr

CoCalc Pull Review Checklist

• does include step-by-step test instructions.
• does solve the problem it claims to
• does NOT introduce new bugs (unless there is a mitigation plan)
• does NOT introduces a denial of service attack vector
• does NOT contains any suspicious TODO (unless there is a mitigation plan)
• does NOT contains significant new code in CoffeeScript; just put that code in typescript in another file and require it.
• does NOT explicitly uses Promises when async/await could be used instead. (We already use this callback library all over, and we use async/await. The last thing we need is doing async three different ways all over the place.)
• does NOT use foo! in TypeScript to avoid null checks; instead do if (foo == null) {...} else {...}.
• does NOT silently ignore errors