Skip to content

Commit 22acaf0

Browse files
committed
Fix tab focus bug on lookup
1 parent d6c1169 commit 22acaf0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

components/SLDSLookup/Menu/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ class Menu extends React.Component {
5454
let className = 'slds-button';
5555
if(this.props.focusIndex === 0) className += ' slds-theme--shade';
5656
return(
57-
<button id="searchDetails" className={className}>
57+
<button id="searchDetails" tabIndex="-1" className={className}>
5858
<Icon name="search" category="utility" size="x-small" className="slds-icon-text-default" />
59-
{this.props.searchTerm ? '"' + this.props.searchTerm + '"' : ""} in {this.props.type}
59+
{this.props.searchTerm ? '"' + this.props.searchTerm + '"' : ""} in {this.props.type + 's'}
6060
</button>
6161
);
6262
}
@@ -65,7 +65,7 @@ class Menu extends React.Component {
6565
let className = 'slds-button';
6666
if(this.props.focusIndex === this.props.listLength + 1) className += ' slds-theme--shade';
6767
return(
68-
<button id="addItem" className={className} onClick={this.props.addItem} onMouseDown={this.props.addItem}>
68+
<button id="addItem" tabIndex="-1" className={className} onClick={this.props.addItem} onMouseDown={this.props.addItem}>
6969
<Icon name="add" category="utility" size="x-small" className="slds-icon-text-default" />
7070
New {this.props.type}
7171
</button>

demo/pages/HomePage/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ module.exports = React.createClass( {
5959
</div>
6060
<main className='stage-main slds-grid slds-wrap slds-grow' role='main'>
6161
<div className='region region--main slds-grow slds-size--1-of-1 slds-medium-size--1-of-2 slds-large-size--8-of-12 slds-col-rule--right slds-p-around--large'>
62-
<LookupBaseSection />
6362

6463
<ButtonSection />
6564

65+
<LookupBaseSection />
6666

6767
<PicklistBaseSection />
6868

0 commit comments

Comments
 (0)