Skip to content

Commit 63c4499

Browse files
committed
added changes based on adam's comments
1 parent 1f0344a commit 63c4499

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

components/progress-indicator/index.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,10 @@ const defaultSteps = [
116116

117117
const defaultProps = {
118118
assistiveText: {
119-
activeStep: 'Active Step',
120-
completedStep: 'Completed Step',
121-
disabledStep: 'Disabled Step',
122-
errorStep: 'Error Step',
119+
activeStep: '',
120+
completedStep: 'Completed',
121+
disabledStep: 'Disabled',
122+
errorStep: 'Error',
123123
step: 'Step',
124124
},
125125
errorSteps: [],

components/progress-indicator/private/progress-bar.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ class ProgressBar extends React.Component {
2828
aria-valuemax="100"
2929
aria-valuenow={this.props.value}
3030
role="progressbar"
31-
tabIndex={0}
3231
>
3332
<span
3433
className="slds-progress-bar__value"

components/progress-indicator/private/step.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ class Step extends React.Component {
117117
const handleFocus = (event) => props.onFocus(event, data);
118118

119119
const stepButton = props.isDisabled ? (
120-
<span
120+
<a
121121
className={classNames(
122122
'slds-button',
123123
{ 'slds-button_icon': renderIcon },
@@ -132,9 +132,9 @@ class Step extends React.Component {
132132
{icon}
133133
<span className="slds-assistive-text">
134134
{this.props.step.assistiveText ||
135-
`${props.assistiveText.step} ${props.index + 1}: ${status}`}
135+
`${props.assistiveText.step} ${props.index + 1}: ${props.step.label} - ${status}`}
136136
</span>
137-
</span>
137+
</a>
138138
) : (
139139
<button
140140
className={classNames(
@@ -152,7 +152,7 @@ class Step extends React.Component {
152152
{icon}
153153
<span className="slds-assistive-text">
154154
{this.props.step.assistiveText ||
155-
`${props.assistiveText.step} ${props.index + 1}: ${status}`}
155+
`${props.assistiveText.step} ${props.index + 1}: ${props.step.label} - ${status}`}
156156
</span>
157157
</button>
158158
);

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)