You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: RELEASENOTES.md
+16Lines changed: 16 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -31,6 +31,22 @@ These are changes that have backwards-compatible solutions present and that comp
31
31
32
32
### Latest Release
33
33
34
+
## Release 0.8.21
35
+
36
+
**Bugfixes**
37
+
38
+
* Positioning behavior of Dialog components that use nubbins has changed. This applies to `Popover`, `Tooltip`, `Datepicker`, `Dropdown`. Previously the nubbin would be misaligned due to hardcoded margins that would get added onto the dialog component. It will now instead calculate the offsets and include them in the positioning logic and add/subtract from the left and top.
39
+
40
+
* Dialogs that use nubbins would previously have the nubbins point at the location on the reference trigger component (i.e. `Button`). Details:
41
+
* If a Popover had an align of `top left`, that meant the nubbin would point at the top left hand side of the `Button`.
42
+
* The behavior now is that the nubbin will always position the Dialog element as needed to ensure it points at the center of the desired side.
43
+
* In the case of a `top left` align the left will only designate the location of the nubbin on the Dialog.
44
+
* We may decide to bring back the ability to control both the nubbin location on the Dialog, but also the location at which it points to on the reference element. Much of the logic surrounding nubbins has been broken at the seams and edge cases for a long time. This change has been done in order to provide a more robust and dependable solution.
45
+
* Any dialog that uses an `offset` prop will need to be manually readjusted.
46
+
* Deprecate `offset` prop for `Dropdown` and `Popover`. The manual setting of positional offset of dialog components has been deemed unreliable. Position logic has been re-written to deliver better and more reliable positioning. Please create an issue if you have an edge case not covered by the built-in logic.
47
+
* In the future we may change the props on some of these Dialog components to ensure a more consistent positioning API with hopefully some less head-scratching in terms of how to use it. This may include deprecating certain props and introduction of other props.
Copy file name to clipboardExpand all lines: components/menu-dropdown/check-props.js
+8Lines changed: 8 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -20,6 +20,14 @@ if (process.env.NODE_ENV !== 'production') {
20
20
'Please use isOpen instead. It provides a consistent prop that aligns with other componenents.'
21
21
);
22
22
23
+
deprecatedProperty(
24
+
COMPONENT,
25
+
props.offset,
26
+
'offset',
27
+
undefined,
28
+
'The manual setting of positional offset of dialog components has been deemed unreliable. Position logic has been re-written to deliver better and more reliable positioning. Please create an issue if you have an edge case not covered by the built-in logic.'
0 commit comments