Skip to content

Commit d6b99f9

Browse files
committed
Merge pull request #6 from salesforce-ux/revert-5-picklistModalIssue
Revert "Fix Picklist in Modal + EventUtil for Testing"
2 parents 48dd601 + 6026122 commit d6b99f9

File tree

3 files changed

+8
-19
lines changed

3 files changed

+8
-19
lines changed

components/SLDSPicklistBase/index.jsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -261,12 +261,7 @@ module.exports = React.createClass( {
261261
this.setState({isOpen:false})
262262
}
263263
}
264-
/* resolve a double click issue with the modal */
265-
} else if (this.props.modal && this.state.isFocused && prevState.isFocused) {
266-
if (!this.state.isOpen) {
267-
this.setState({isOpen : true});
268-
}
269-
}
264+
}
270265

271266

272267
if(this.props.value !== prevProps.value){

components/SLDSPicklistBase/list-item.jsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ module.exports = React.createClass({
9090
this.props.onMoveFocus(-1);
9191
}
9292
}
93-
else if(event.keyCode === KEYS.ENTER ||
93+
else if(event.keyCode === KEYS.ENTER ||
9494
event.keyCode === KEYS.SPACE ){
9595
EventUtil.trapEvent(event);
9696
if(this.props.onSelect){
@@ -116,9 +116,7 @@ module.exports = React.createClass({
116116
},
117117

118118
handleBlur(e) {
119-
if (this.props.onBlur &&
120-
this.refs.link.getDOMNode() !== e.target) {
121-
119+
if(this.props.onBlur){
122120
this.props.onBlur(this.props.index, e.relatedTarget);
123121
}
124122
},
@@ -132,15 +130,15 @@ module.exports = React.createClass({
132130

133131
render () {
134132
return (
135-
<li
133+
<li
136134

137135
className={"slds-dropdown__item slds-has-icon slds-has-icon--left slds-theme--"+this.props.theme}
138136
onMouseDown={this.handleMouseDown}
139137
tabIndex={-1}>
140138
<a id={'menu-0-'+this.props.index}
141139
href=''
142140
ref='link'
143-
className='slds-truncate'
141+
className='slds-truncate'
144142
onClick={this.handleClick}
145143
onMouseDown={this.handleMouseDown}
146144
onKeyDown={this.handleKeyDown}

components/utils/EventUtil.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,8 @@ const EventUtil = {
1616
trapEvent(event){
1717
event.preventDefault();
1818
event.stopPropagation();
19-
20-
if(event.nativeEvent && event.nativeEvent.preventDefault){
19+
if(event.nativeEvent){
2120
event.nativeEvent.preventDefault();
22-
}
23-
24-
if (event.nativeEvent && event.nativeEvent.stopPropagation){
2521
event.nativeEvent.stopPropagation();
2622
}
2723
},
@@ -31,12 +27,12 @@ const EventUtil = {
3127
},
3228

3329
trapImmediate(event){
34-
if(event.nativeEvent && event.nativeEvent.stopImmediatePropagation){
30+
if(event.nativeEvent){
3531
event.nativeEvent.stopImmediatePropagation();
3632
}
3733
EventUtil.trap(event);
3834
}
3935

4036
};
4137

42-
module.exports = EventUtil;
38+
module.exports = EventUtil;

0 commit comments

Comments
 (0)