Skip to content

Commit e6e2344

Browse files
committed
More lint issues and potentially fixes the voiceover tooltip issue
1 parent 2c9d891 commit e6e2344

File tree

4 files changed

+18
-5
lines changed

4 files changed

+18
-5
lines changed

components/menu-dropdown/check-props.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,13 @@ if (process.env.NODE_ENV !== 'production') {
2020
'Please use isOpen instead. It provides a consistent prop that aligns with other componenents.'
2121
);
2222

23-
deprecatedProperty(COMPONENT,
24-
props.offset, 'offset', undefined, 'The manual setting of positional offset of dialog components has been deemed unreliable. Position logic has been re-written to deliver better and more reliable positioning. Please create an issue if you have an edge case not covered by the built-in logic.');
23+
deprecatedProperty(
24+
COMPONENT,
25+
props.offset,
26+
'offset',
27+
undefined,
28+
'The manual setting of positional offset of dialog components has been deemed unreliable. Position logic has been re-written to deliver better and more reliable positioning. Please create an issue if you have an edge case not covered by the built-in logic.'
29+
);
2530

2631
oneOfRequiredProperty(COMPONENT, {
2732
options: props.options,

components/popover/check-props.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,13 @@ if (process.env.NODE_ENV !== 'production') {
2424
]);
2525
}
2626

27-
deprecatedProperty(COMPONENT,
28-
props.offset, 'offset', undefined, 'The manual setting of positional offset of dialog components has been deemed unreliable. Position logic has been re-written to deliver better and more reliable positioning. Please create an issue if you have an edge case not covered by the built-in logic.');
27+
deprecatedProperty(
28+
COMPONENT,
29+
props.offset,
30+
'offset',
31+
undefined,
32+
'The manual setting of positional offset of dialog components has been deemed unreliable. Position logic has been re-written to deliver better and more reliable positioning. Please create an issue if you have an edge case not covered by the built-in logic.'
33+
);
2934

3035
deprecatedProperty(
3136
COMPONENT,

components/popover/popover.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@ const Popover = createReactClass({
547547

548548
this.renderOverlay(this.getIsOpen());
549549

550-
const containerStyles = { display: 'inline-block' }; // ATTN FIXME - can we make this change??!
550+
const containerStyles = { display: 'inline-block' };
551551
return (
552552
<div
553553
className={this.props.triggerClassName}

components/tooltip/index.jsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,9 @@ class Tooltip extends React.Component {
219219
onRequestTargetElement={() => this.getTooltipTarget()}
220220
position={this.props.position}
221221
variant="tooltip"
222+
containerProps={{
223+
id: this.getId()
224+
}}
222225
>
223226
{this.getTooltipContent()}
224227
</Dialog>

0 commit comments

Comments
 (0)