Skip to content

Commit f33e09c

Browse files
Merge pull request #2331 from kevinparkerson/progress-bar-a11y-audit-fixes
Make ProgressBar read "{value}%" instead of just "{value}"
2 parents 1ae1397 + 17b7186 commit f33e09c

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

components/progress-bar/__docs__/__snapshots__/storybook-stories.storyshot

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ exports[`DOM snapshots SLDSProgressBar Color 1`] = `
2121
aria-valuemax="100"
2222
aria-valuemin="0"
2323
aria-valuenow={75}
24+
aria-valuetext="Progress: 75%"
2425
className="slds-progress-bar"
2526
role="progressbar"
2627
>
@@ -63,6 +64,7 @@ exports[`DOM snapshots SLDSProgressBar Default 1`] = `
6364
aria-valuemax="100"
6465
aria-valuemin="0"
6566
aria-valuenow={75}
67+
aria-valuetext="Progress: 75%"
6668
className="slds-progress-bar"
6769
role="progressbar"
6870
>
@@ -118,9 +120,11 @@ exports[`DOM snapshots SLDSProgressBar Descriptive 1`] = `
118120
</span>
119121
</div>
120122
<div
123+
aria-labelledby="progress-bar-label-setup-progress-bar"
121124
aria-valuemax="100"
122125
aria-valuemin="0"
123126
aria-valuenow={90}
127+
aria-valuetext="Progress: 90%"
124128
className="slds-progress-bar"
125129
role="progressbar"
126130
>
@@ -166,6 +170,7 @@ exports[`DOM snapshots SLDSProgressBar Radius 1`] = `
166170
aria-valuemax="100"
167171
aria-valuemin="0"
168172
aria-valuenow={75}
173+
aria-valuetext="Progress: 75%"
169174
className="slds-progress-bar slds-progress-bar_circular"
170175
role="progressbar"
171176
>
@@ -211,6 +216,7 @@ exports[`DOM snapshots SLDSProgressBar Thickness 1`] = `
211216
aria-valuemax="100"
212217
aria-valuemin="0"
213218
aria-valuenow={90}
219+
aria-valuetext="Progress: 90%"
214220
className="slds-progress-bar slds-progress-bar_x-small"
215221
role="progressbar"
216222
>
@@ -248,6 +254,7 @@ exports[`DOM snapshots SLDSProgressBar Thickness 1`] = `
248254
aria-valuemax="100"
249255
aria-valuemin="0"
250256
aria-valuenow={75}
257+
aria-valuetext="Progress: 75%"
251258
className="slds-progress-bar slds-progress-bar_small"
252259
role="progressbar"
253260
>
@@ -285,6 +292,7 @@ exports[`DOM snapshots SLDSProgressBar Thickness 1`] = `
285292
aria-valuemax="100"
286293
aria-valuemin="0"
287294
aria-valuenow={50}
295+
aria-valuetext="Progress: 50%"
288296
className="slds-progress-bar slds-progress-bar_medium"
289297
role="progressbar"
290298
>
@@ -322,6 +330,7 @@ exports[`DOM snapshots SLDSProgressBar Thickness 1`] = `
322330
aria-valuemax="100"
323331
aria-valuemin="0"
324332
aria-valuenow={25}
333+
aria-valuetext="Progress: 25%"
325334
className="slds-progress-bar slds-progress-bar_large"
326335
role="progressbar"
327336
>
@@ -363,6 +372,7 @@ exports[`DOM snapshots SLDSProgressBar Vertical 1`] = `
363372
aria-valuemax="100"
364373
aria-valuemin="0"
365374
aria-valuenow={60}
375+
aria-valuetext="Progress: 60%"
366376
className="slds-progress-bar slds-progress-bar_vertical"
367377
role="progressbar"
368378
>

components/progress-bar/index.jsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,15 @@ class ProgressBar extends React.Component {
136136
{this.props.orientation === 'horizontal' &&
137137
this.getDescription({ labels })}
138138
<div
139+
aria-labelledby={
140+
this.props.orientation === 'horizontal' && labels.label
141+
? `progress-bar-label-${this.getId()}`
142+
: undefined
143+
}
139144
aria-valuemin="0"
140145
aria-valuemax="100"
141146
aria-valuenow={this.props.value}
147+
aria-valuetext={`${assistiveText.progress}: ${this.props.value}%`}
142148
role="progressbar"
143149
className={classNames(
144150
'slds-progress-bar',

components/setup-assistant/__docs__/__snapshots__/storybook-stories.storyshot

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1615,9 +1615,11 @@ exports[`DOM snapshots SLDSSetupAssistant In a Card 1`] = `
16151615
</span>
16161616
</div>
16171617
<div
1618+
aria-labelledby="progress-bar-label-card-setup-assistant-progress-bar"
16181619
aria-valuemax="100"
16191620
aria-valuemin="0"
16201621
aria-valuenow={50}
1622+
aria-valuetext="Progress: 50%"
16211623
className="slds-progress-bar slds-progress-bar_circular"
16221624
role="progressbar"
16231625
>

0 commit comments

Comments
 (0)