Skip to content

Update the PropType of ContextBar links #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2016
Merged

Update the PropType of ContextBar links #363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8271679
Update the PropType of ContextBar links
Jun 29, 2016
ec32198
Update ContextBar link to new event standard
Jun 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions components/context-bar/link.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ const ContextBarLink = (props) => {
function handleClick (event) {
if (isFunction(onClick)) {
EventUtil.trap(event);

event.href = this.props.href;
onClick(event);
}
}
Expand Down Expand Up @@ -77,9 +79,9 @@ ContextBarLink.propTypes = {
*/
label: PropTypes.string,
/**
* Function triggered when link is clicked. If set, `href` will be ignored.
* `function (event)` - fires when the link is clicked. If set, `href` will be ignored, but includes the `href` of the link in the event object.
*/
onClick: PropTypes.string
onClick: PropTypes.func
};

module.exports = ContextBarLink;