Skip to content

Adjust typography on the example page #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 23, 2020

Conversation

przemyslawzalewski
Copy link
Member

The following typographic issues were fixed/adjusted:

  • The footer text is now always centered
  • Line heights were increased to 170% of the font size
  • Horizontal margins for text copy was introduced to never make it stick to the phone chrome or screen borders
  • Fallback text for action trigger status is now displayed to prevent empty space being shown until the user triggers some action
  • A more semantic h1 tag replaced the h3 tag of the page title but still uses the same styling.

chrome_2020-01-23_10-01-29

@przemyslawzalewski przemyslawzalewski merged commit 72c8c0d into master Jan 23, 2020
@przemyslawzalewski przemyslawzalewski deleted the adjust_example_page_typography branch January 23, 2020 10:32
@marekrozmus
Copy link

@all-contributors please add @przemyslawzalewski for code, ideas

@allcontributors
Copy link
Contributor

@marekrozmus

I've put up a pull request to add @przemyslawzalewski! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants