Skip to content

Introduce pysassc (will be migrated to) #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2017
Merged

Introduce pysassc (will be migrated to) #218

merged 1 commit into from
Sep 20, 2017

Conversation

asottile
Copy link
Member

Refs #134

@asottile asottile requested a review from dahlia September 20, 2017 18:43
@dahlia
Copy link
Member

dahlia commented Sep 20, 2017

It would be better if sassc:main prints a warning when sys.argv[0] == 'sassc'.

@asottile
Copy link
Member Author

I'm planning on following up with a warning if that's ok.

  • next release: add pysassc
  • next next release: issue deprecation warning in sassc
  • (some time after): change warning to error
  • (some time after): remove sassc

dahlia
dahlia approved these changes Sep 20, 2017
View reviewed changes
Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@asottile asottile merged commit 8efb498 into master Sep 20, 2017
@asottile asottile deleted the introduce_pysassc branch September 20, 2017 21:05
@asottile asottile mentioned this pull request Sep 20, 2017
Closed
@asottile
Copy link
Member Author

This has been released as part of 0.13.3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlia dahlia dahlia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asottile @dahlia