Upgrade to 3.4.9 #232
Upgrade to 3.4.9 #232
Conversation
|
yay, sourcemaps changed -- this makes sense now that they're unicode aware (reading through changelogs) -- I'll go update them |
|
hrmmm though segfault on posix -- seems like there might be an upstream bug here... trying to get a trace... |
|
trying to get a core dump but not doing so well -- I'm not on my usual computer. @xzyfer just in case it is actually a problem -- we're seeing segfaults with 3.4.9 that we weren't seeing with 3.4.8 -- I'll try and make a minimal reproduction |
|
cc @mgreter who is managing 3.4.x releases
…On 6 Feb. 2018 10:53 am, "Anthony Sottile" ***@***.***> wrote:
trying to get a core dump but not doing so well -- I'm not on my usual
computer.
@xzyfer <https://github.com/xzyfer> just in case it is actually a problem
-- we're seeing segfaults with 3.4.9 that we weren't seeing with 3.4.8 --
I'll try and make a minimal reproduction
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#232 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWIc3Itgfp_VSYbZSR7gVYlwYFYDdks5tR5RhgaJpZM4R6Pks>
.
|
|
I had to delete the first tagging since I saw the same error on perl-libsass (it was maybe up for 30 minutes). Are you sure you have sass/libsass@6de5050 included? Sorry for the inconvenience. |
|
ah nice -- I was too quick! I'll try again with the new tag -- thanks 🎉 |
|
Cool, I guess we should add some tests in libsass directly to catch these errors. |
|
awesome -- let me know if you'd like some help with that :) |
|
IMO we would need something like https://github.com/sass/libsass/blob/master/docs/api-function-example.md for travis and appveyor to test custom functions/importers directly. I don't see any other easy way to cover this in our CI otherwise. If you can come up with a PR that would be great ;) |
|
I'll see what I can cook up in my copious amounts of freetime, I've added it to the top of my "todo" list :) |
No description provided.