Allow partials and other non-function callables as importer callbacks #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops. Missed a flake8 issue. Will force push a correction. |
fdintino
force-pushed
the
fix-importer-argspec
branch
from
7ba30fb to
4866296
Compare
|
Thanks again! Let me know how this branch works for you and I can make a release soon :) |
|
This works perfectly. Thanks! |
|
Any idea on when this might make it into a release? |
|
I'll do this tonight, so in a few hours :) |
|
0.18.0 is released, the windows wheels will be up in ~an hour and the mac wheels will be up tomorrow if I remember |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow up PR based on the discussion in #287.
I removed the
functools.wrapsdecorator because it doesn't work withobject.__call__orfunctools.partial(since neither have the__name__attribute). But it seemed unnecessary anyway because (as far as I can tell) the wrapped functions aren't exposed to the user.