Updating tests in EvalEndpointSpec and in EvaluatorSpec

Author: dominv

server/src/test/scala/org/scalaexercises/evaluator/EvalEndpointSpec.scala

@@ -212,14 +212,14 @@ class EvalEndpointSpec extends FunSpec with Matchers {
       )
     }
 
-    it("evaluates the code when a list of compilerFlags is provided") {
+    it("evaluates the code when a list of allowed compilerFlags is provided") {
       verifyEvalResponse(
         response = serve(
           EvalRequest(
             code = "{import cats._; Eval.now(42).value}",
             resolvers = sonatypeReleases,
             dependencies = Dependency("org.typelevel", "cats_2.11", "0.6.0") :: Nil,
-            compilerFlags = List("-optimise", "-help")
+            compilerFlags = List("-deprecation", "-feature")
           ),
           `X-Scala-Eval-Api-Token`(validToken)),
         expectedStatus = HttpStatus.Ok,
@@ -228,5 +228,17 @@ class EvalEndpointSpec extends FunSpec with Matchers {
       )
     }
 
+    it("rejects requests with invalid compilerFlags") {
+      serve(
+        EvalRequest(
+          code = "1",
+          resolvers = Nil,
+          dependencies = Nil,
+          compilerFlags = List("-optimise", "-help")
+        ),
+        `X-Scala-Eval-Api-Token`(validToken)).status should be(
+        HttpStatus.BadRequest)
+    }
+
   }
 }

server/src/test/scala/org/scalaexercises/evaluator/EvaluatorSpec.scala

@@ -162,12 +162,13 @@ class EvaluatorSpec extends FunSpec with Matchers {
       }
     }
 
-    describe("can evaluate code with a list of compiler flags provided") {
+    describe(
+      "can evaluate code with a list of allowed compiler flags provided") {
       val code = "{import cats._; Eval.now(42).value}"
 
       val dependencies = Dependency("org.typelevel", "cats_2.11", "0.6.0") :: Nil
 
-      val compilerFlags = List("-X", "-help")
+      val compilerFlags = List("-deprecation", "-feature")
 
       val result: EvalResult[Unit] = evaluator
         .eval(