Implement HashSet.-= in terms of remove, not the other way around.

Author: sjrd

compiler/src/dotty/tools/dotc/util/HashSet.scala

@@ -97,7 +97,7 @@ class HashSet[T](initialCapacity: Int = 8, capacityMultiple: Int = 2) extends Mu
 
   def +=(x: T): Unit = put(x)
 
-  def -= (x: T): Unit =
+  def remove(x: T): Boolean =
     Stats.record(statsItem("remove"))
     var idx = firstIndex(x)
     var e = entryAt(idx)
@@ -117,16 +117,13 @@ class HashSet[T](initialCapacity: Int = 8, capacityMultiple: Int = 2) extends Mu
             hole = idx
         table(hole) = null
         used -= 1
-        return
+        return true
       idx = nextIndex(idx)
       e = entryAt(idx)
+    false
 
-  def remove(x: T): Boolean =
-    if contains(x) then
-      this -= x
-      true
-    else
-      false
+  def -=(x: T): Unit =
+    remove(x)
 
   private def addOld(x: T) =
     Stats.record(statsItem("re-enter"))