Fix potential bug in IsDefinition

Blaisorblade · nicolasstucki · commit 1489a0628ef4 · 2018-08-09T15:40:56.000+02:00
diff --git a/compiler/src/dotty/tools/dotc/tastyreflect/TastyImpl.scala b/compiler/src/dotty/tools/dotc/tastyreflect/TastyImpl.scala
@@ -133,11 +133,12 @@ class TastyImpl(val rootContext: Contexts.Context) extends scala.tasty.Tasty wit
 
   // ----- Definitions ----------------------------------------------
 
-  type Definition = tpd.Tree
+  type Definition = tpd.Tree /* tpd.MemberDef | PackageDefinition */
 
   object IsDefinition extends IsDefinitionExtractor {
     def unapply(tree: Tree)(implicit ctx: Context): Option[Definition] = tree match {
       case tree: tpd.MemberDef => Some(tree)
+      case tree: PackageDefinition => Some(tree)
       case _ => None
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -133,11 +133,12 @@ class TastyImpl(val rootContext: Contexts.Context) extends scala.tasty.Tasty wit`
`133`	`133`
`134`	`134`	`// ----- Definitions ----------------------------------------------`
`135`	`135`
`136`		`- type Definition = tpd.Tree`
	`136`	`+ type Definition = tpd.Tree /* tpd.MemberDef \| PackageDefinition */`
`137`	`137`
`138`	`138`	`object IsDefinition extends IsDefinitionExtractor {`
`139`	`139`	`def unapply(tree: Tree)(implicit ctx: Context): Option[Definition] = tree match {`
`140`	`140`	`case tree: tpd.MemberDef => Some(tree)`
	`141`	`+ case tree: PackageDefinition => Some(tree)`
`141`	`142`	`case _ => None`
`142`	`143`	`}`
`143`	`144`	`}`