Remove needsHealing

Author: nicolasstucki

compiler/src/dotty/tools/dotc/transform/PCPCheckAndHeal.scala

@@ -49,8 +49,9 @@ class PCPCheckAndHeal(@constructorOnly ictx: Context) extends TreeMapWithStages(
     else tree match {
 
       case _: TypeTree | _: RefTree if tree.isType  =>
-        if needsHealing(tree.tpe) then TypeTree(healType(tree.sourcePos)(tree.tpe)).withSpan(tree.span)
-        else tree
+        val healedType = healType(tree.sourcePos)(tree.tpe)
+        if healedType == tree.tpe then tree
+        else TypeTree(healedType).withSpan(tree.span)
 
       case _: This =>
         if level != levelOf(tree.symbol) then
@@ -135,21 +136,7 @@ class PCPCheckAndHeal(@constructorOnly ictx: Context) extends TreeMapWithStages(
 
   /** Heal types in the info of the given tree */
   private def healInfo(tree: Tree, pos: SourcePosition)(using Context): Unit =
-    if needsHealing(tree.symbol.info) then
-      tree.symbol.info = healType(pos)(tree.symbol.info)
-
-  /** Does this type contain a phase inconsistent reference? */
-  private def needsHealing(tp: Type)(using Context) = new ExistsAccumulator(
-    _ match
-      case tp @ TypeRef(NoPrefix, _) =>
-        level > levelOf(tp.symbol)
-      case tp @ TermRef(NoPrefix, _) =>
-        level != levelOf(tp.symbol)
-      case tp: ThisType =>
-        level != levelOf(tp.cls)
-      case tp =>
-        tp.typeSymbol.isSplice && level > 0
-  ).apply(false, tp)
+    tree.symbol.info = healType(pos)(tree.symbol.info)
 
   private def healType(pos: SourcePosition)(using Context) = new TypeMap {
     def apply(tp: Type): Type =