Merge pull request #9323 from dotty-staging/fix-#9290

Fix #9290: Insert correct package object for overloaded definitions

Author: odersky

compiler/src/dotty/tools/dotc/core/TypeOps.scala

@@ -461,7 +461,13 @@ object TypeOps:
   def makePackageObjPrefixExplicit(tpe: NamedType)(using Context): Type = {
     def tryInsert(pkgClass: SymDenotation): Type = pkgClass match {
       case pkg: PackageClassDenotation =>
-        val pobj = pkg.packageObjFor(tpe.symbol)
+        var sym = tpe.symbol
+        if !sym.exists && tpe.denot.isOverloaded then
+          // we know that all alternatives must come from the same package object, since
+          // otherwise we would get "is already defined" errors. So we can take the first
+          // symbol we see.
+          sym = tpe.denot.alternatives.head.symbol
+        val pobj = pkg.packageObjFor(sym)
         if (pobj.exists) tpe.derivedSelect(pobj.termRef)
         else tpe
       case _ =>

tests/pos/i9290/Test.scala

@@ -0,0 +1,9 @@
+package sudoku
+
+final case class SudokuField(sudoku: Int)
+
+// This form compiles only when package.scala is commented.
+// This form compiles with error when package.scala is uncommented.
+implicit class SudokuFieldOps(val sudokuField: SudokuField) extends AnyVal {
+  def foo: Int = ???
+}

tests/pos/i9290/package.scala

@@ -0,0 +1 @@
+package object sudoku {}