Add test

Author: liufengyun

compiler/src/dotty/tools/dotc/transform/init/ParamOverridingCheck.scala

@@ -15,6 +15,7 @@ import reporting.trace as log
 
 import Semantic.Arg
 import Semantic.NewExpr
+import Semantic.Call
 import Semantic.hasSource
 
 import scala.collection.mutable
@@ -102,6 +103,7 @@ object ParamOverridingCheck:
           Unknown(source)
     }
 
+  extension (thisV: ThisRef)
     def callConstructor(ctor: Symbol, args: List[Value]): Contextual[Unit] = log("call " + ctor.show + ", args = " + args, printer) {
       // init "fake" param fields for parameters of primary and secondary constructors
       def addParamsAsFields(args: List[Value], ref: ThisRef, ctorDef: DefDef) =
@@ -111,19 +113,19 @@ object ParamOverridingCheck:
           ref.initField(param, value)
           printer.println(param.show + " initialized with " + value)
 
-      value match
-        case ref: ThisRef =>
-          if ctor.hasSource then
-            val cls = ctor.owner.enclosingClass.asClass
-            val ddef = ctor.defTree.asInstanceOf[DefDef]
-            addParamsAsFields(args, ref, ddef)
-            if ctor.isPrimaryConstructor then
-              val tpl = cls.defTree.asInstanceOf[TypeDef].rhs.asInstanceOf[Template]
-              eval(tpl, ref, cls)
-            else
-              eval(ddef.rhs, ref, cls)
+      if ctor.hasSource then
+        val cls = ctor.owner.enclosingClass.asClass
+        val ddef = ctor.defTree.asInstanceOf[DefDef]
+        addParamsAsFields(args, thisV, ddef)
+        if ctor.isPrimaryConstructor then
+          val tpl = cls.defTree.asInstanceOf[TypeDef].rhs.asInstanceOf[Template]
+          init(tpl, thisV, cls)
+        else
+          ddef.rhs match
+          case Block(Call(ref, argss) :: _, _) =>
+            val args = evalArgs(argss.flatten, thisV, thisV.klass)
+            thisV.callConstructor(ref.symbol, args)
 
-        case _ =>
     }
   end extension
 
@@ -306,16 +308,19 @@ object ParamOverridingCheck:
 
     // check parameter access semantics
     for
-      paramAcc <- klass.paramGetters
-      overridingSym = paramAcc.overridingSymbol(thisV.klass)
+      paramSym <- klass.paramGetters
+      overridingSym = paramSym.overridingSymbol(thisV.klass)
       if overridingSym.exists
     do
+      // println(paramSym.show + " is overridden in " + thisV.klass)
       if !overridingSym.is(Flags.ParamAccessor) then
-        report.warning("Overriding class parameter " + paramAcc.name + " in " + klass + " with non-class-parameter in " + thisV.klass, overridingSym.defTree)
+        report.warning("Overriding parameter " + paramSym.show + " in " + klass + " as non-parameter in " + thisV.klass, overridingSym.defTree)
       else
         val overridingValue = thisV.field(overridingSym)
-        if thisV.field(paramAcc) != overridingValue then
-          report.warning("Incorrect overriding, " + paramAcc + " in " + klass + " have different value from " + overridingSym + " in " + thisV.klass, overridingValue.source)
+        // println(overridingSym.show + " in " + thisV.klass + " = " + overridingValue)
+        // println(paramSym.show + " in " + klass + " = " + thisV.field(paramSym))
+        if thisV.field(paramSym) != overridingValue then
+          report.warning("Incorrect overriding: " + paramSym.show + " in " + klass + " have different value from " + overridingSym.show + " in " + thisV.klass, overridingValue.source)
 
     thisV
   }

tests/init/neg/i15764.scala

@@ -0,0 +1,7 @@
+class B(val y: Int):
+  println(y)                   // A warning is due here
+  foo()
+  def foo() = println(y)
+
+class C(override val y: Int) extends B(10)  // error
+