Skip to content

Commit 36f4fb7

Browse files
committed
add missing headers. fix tabs
1 parent 293cd13 commit 36f4fb7

File tree

3 files changed

+18
-9
lines changed

3 files changed

+18
-9
lines changed

scaladoc/resources/dotty_res/scripts/ux.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ window.addEventListener("DOMContentLoaded", () => {
3030
}
3131
}
3232

33-
var memberLists = document.getElementsByClassName("membersList")
33+
var memberLists = document.getElementsByClassName("tab")
3434
if (memberLists) {
3535
for (i = 0; i < memberLists.length; i++) {
3636
memberLists[i].children[0].onclick = function(e) {

scaladoc/resources/dotty_res/styles/theme/layout/content.css

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -363,27 +363,27 @@
363363
margin-bottom: calc(3 * var(--base-spacing));
364364
}
365365

366-
.membersList {
366+
.tab {
367367
position: relative;
368368
}
369369

370-
.membersList h2 {
370+
.tab h2 {
371371
border-bottom: 1px solid var(--border-default);
372372
padding-bottom: calc(3 * var(--base-spacing));
373373
padding-top: calc(3 * var(--base-spacing));
374374
}
375375

376-
.membersList > button {
376+
.tab > button {
377377
position: absolute;
378378
right: 0;
379379
top: calc(3.5 * var(--base-spacing));
380380
}
381381

382-
.membersList .documentableList {
382+
.tab .documentableList {
383383
display: none;
384384
}
385385

386-
.membersList.expand .documentableList {
386+
.tab.expand .documentableList {
387387
display: block;
388388
}
389389

scaladoc/src/dotty/tools/scaladoc/renderers/MemberRenderer.scala

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ class MemberRenderer(signatureRenderer: SignatureRenderer)(using DocContext) ext
125125
Option.when(bodyContents.nonEmpty || attributes.nonEmpty)(
126126
div(cls := "cover")(
127127
div(cls := "doc")(bodyContents),
128+
h1(cls := "h500")("Attributes"),
128129
dl(cls := "attributes")(attributes*)
129130
)
130131
)
@@ -260,7 +261,15 @@ class MemberRenderer(signatureRenderer: SignatureRenderer)(using DocContext) ext
260261

261262
val children = all.flatten.flatten
262263
if children.isEmpty then emptyTab
263-
else Tab(name, name, h2(tabAttr(name), cls := "h300")(name) +: children, "selected")
264+
else Tab(
265+
name,
266+
name,
267+
Seq(
268+
button(cls := "icon-button show-content expand"),
269+
h2(tabAttr(name), cls := "h300")(name)
270+
) ++ children,
271+
"expand"
272+
)
264273

265274
case class ExpandedGroup(name: AppliedTag, description: AppliedTag, prio: Int)
266275

@@ -289,7 +298,7 @@ class MemberRenderer(signatureRenderer: SignatureRenderer)(using DocContext) ext
289298
members.map(member)
290299
))
291300
}
292-
Tab("Grouped members", "custom_groups", content, "selected")
301+
Tab("Grouped members", "custom_groups", content, "expand")
293302

294303
def buildMembers(s: Member): AppliedTag =
295304
def partitionIntoGroups(members: Seq[Member]) =
@@ -318,7 +327,7 @@ class MemberRenderer(signatureRenderer: SignatureRenderer)(using DocContext) ext
318327
}.toSeq
319328

320329
div(cls := "membersList expand")(
321-
button(cls := "icon-button show-content expand"),
330+
h1(cls := "h500")("Members list"),
322331
renderTabs(
323332
singleSelection = false,
324333
buildGroup("Packages", Seq(

0 commit comments

Comments
 (0)