Add support for scaladoc2 anchors

Author: pikinier20

scaladoc-testcases/src/tests/externalLocations/scaladoc2.scala

@@ -10,3 +10,5 @@ class Test {
   def c: Regex.Match = ???
 }
 
+abstract class MySeq[T] extends scala.collection.immutable.Seq[T]
+

scaladoc/src/dotty/tools/scaladoc/tasty/Scaladoc2AnchorCreator.scala

@@ -0,0 +1,21 @@
+package dotty.tools.scaladoc
+package tasty
+
+import scala.quoted._
+import dotty.tools.scaladoc.util.Escape._
+import scala.util.matching.Regex
+
+trait Scaladoc2AnchorCreator:
+  self: SymOps[_] =>
+
+  import self.q.reflect._
+
+  implicit private val printer: Printer[Tree] = Printer.TreeShortCode
+
+  def getScaladoc2Type(t: Tree) = {
+    (t match {
+    case d: DefDef => d.show.split("def", 2)(1)
+    case t: TypeDef => t.show.split("type", 2)(1)
+    case v: ValDef => v.show.split("val|var", 2)(1)
+  }).replace(" ","")
+}

scaladoc/src/dotty/tools/scaladoc/tasty/SymOps.scala

@@ -4,7 +4,7 @@ package tasty
 import scala.quoted._
 import dotty.tools.scaladoc.util.Escape._
 
-class SymOps[Q <: Quotes](val q: Q) extends JavadocAnchorCreator:
+class SymOps[Q <: Quotes](val q: Q) extends JavadocAnchorCreator with Scaladoc2AnchorCreator:
   import q.reflect._
 
   given Q = q
@@ -115,17 +115,21 @@ class SymOps[Q <: Quotes](val q: Q) extends JavadocAnchorCreator:
       val docURL = link.documentationUrl.toString
       def constructPathForJavadoc: String =
         val l = "\\$+".r.replaceAllIn(location.replace(".","/"), _ => ".")
-        val javadocAnchor = {
+        val javadocAnchor = if anchor.isDefined then {
           val paramSigs = sym.paramSymss.flatten.map(_.tree).collect {
             case v: ValDef => v.tpt.tpe
           }.map(getJavadocType)
-          paramSigs.mkString("-","-","-")
-        }
-        docURL + l + extension + anchor.fold("")(a => "#" + sym.name + javadocAnchor)
+          "#" + sym.name + paramSigs.mkString("-","-","-")
+        } else ""
+        docURL + l + extension + javadocAnchor
 
       //TODO #263: Add anchor support
       def constructPathForScaladoc2: String =
-        docURL + escapeUrl(location).replace(".", "/") + extension
+        val l = escapeUrl(location).replace(".", "/")
+        val scaladoc2Anchor = if anchor.isDefined then {
+          "#" + getScaladoc2Type(sym.tree)
+        } else ""
+        docURL + l + extension + scaladoc2Anchor
 
       // TODO Add tests for it!
       def constructPathForScaladoc3: String =

scaladoc/test/dotty/tools/scaladoc/ExternalLocationProviderIntegrationTest.scala

@@ -28,8 +28,10 @@ class Scaladoc2ExternalLocationProviderIntegrationTest extends ExternalLocationP
   List(".*scala.*::scaladoc2::https://www.scala-lang.org/api/current/"),
   List(
     "https://www.scala-lang.org/api/current/scala/util/matching/Regex$$Match.html",
-    "https://www.scala-lang.org/api/current/scala/Predef$.html",
-    "https://www.scala-lang.org/api/current/scala/collection/immutable/Map.html"
+    "https://www.scala-lang.org/api/current/scala/Predef$.html#String",
+    "https://www.scala-lang.org/api/current/scala/collection/immutable/Map.html",
+    "https://www.scala-lang.org/api/current/scala/collection/IterableOnceOps.html#addString(b:StringBuilder,start:String,sep:String,end:String):StringBuilder",
+    "https://www.scala-lang.org/api/current/scala/collection/IterableOnceOps.html#mkString(start:String,sep:String,end:String):String"
   )
 )