Fix #4732: Root the desugared call to StringContext

* Make desugared `s""` call `_root_.scala.StringContext` instead
  of just `StringContext` to fix the initial issue
* Add a unit test to lock in the change
* Update StringInterpolatorOpt#unapply so that the StringInterpolator
  optimistation can work with the new change

Author: lloydmeta

compiler/src/dotty/tools/dotc/ast/Desugar.scala

@@ -1109,8 +1109,13 @@ object desugar {
           case Block(Nil, expr) => expr // important for interpolated string as patterns, see i1773.scala
           case t => t
         }
-
-        Apply(Select(Apply(Ident(nme.StringContext), strs), id), elems)
+        // This is a deliberate departure from scalac, where StringContext is not rooted (See #4732)
+        val rootedStringContext = {
+          val rootPkg = Ident(nme.ROOTPKG)
+          val scalaPkg = Select(rootPkg, nme.scala_)
+          Select(scalaPkg, nme.StringContext)
+        }
+        Apply(Select(Apply(rootedStringContext, strs), id), elems)
       case InfixOp(l, op, r) =>
         if (ctx.mode is Mode.Type)
           AppliedTypeTree(op, l :: r :: Nil) // op[l, r]

compiler/src/dotty/tools/dotc/transform/localopt/StringInterpolatorOpt.scala

@@ -36,7 +36,7 @@ class StringInterpolatorOpt extends MiniPhase {
     def unapply(tree: Select)(implicit ctx: Context): Boolean = {
       tree.symbol.eq(defn.StringContextModule_apply) && {
         val qualifier = tree.qualifier
-        qualifier.isInstanceOf[Ident] && qualifier.symbol.eq(defn.StringContextModule)
+        qualifier.isInstanceOf[Select] && qualifier.symbol.eq(defn.StringContextModule)
       }
     }
   }

tests/run/rooted_stringcontext.check

@@ -0,0 +1 @@
+Answer: 42

tests/run/rooted_stringcontext.scala

@@ -0,0 +1,10 @@
+object StringContext {
+  val i = 42
+  val s = s"Answer: $i"
+}
+
+object Test {
+  def main(args: Array[String]): Unit = {
+    println(StringContext.s)
+  }
+}