Skip to content

Commit 44dddbb

Browse files
rsshnicolasstucki
andauthored
Apply suggestions from code review (form without returnType in tests)
Co-authored-by: Nicolas Stucki <[email protected]>
1 parent 2b1c0ee commit 44dddbb

File tree

6 files changed

+11
-11
lines changed

6 files changed

+11
-11
lines changed

tests/pos-macros/i6535/Macro_1.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ object scalatest {
1212
case t @ Apply(Select(lhs, op), rhs :: Nil) =>
1313
let(lhs) { left =>
1414
let(rhs) { right =>
15-
val app = Select.overloaded(left, op, Nil, right :: Nil, TypeBounds.minmax)
15+
val app = Select.overloaded(left, op, Nil, right :: Nil)
1616
let(app) { result =>
1717
val l = left.seal
1818
val r = right.seal

tests/run-macros/i5941/macro_1.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ object Lens {
1919
def setterBody(obj: Term, value: Term, parts: List[String]): Term = {
2020
// o.copy(field = value)
2121
def helper(obj: Term, value: Term, field: String): Term =
22-
Select.overloaded(obj, "copy", Nil, NamedArg(field, value) :: Nil, TypeBounds.minmax)
22+
Select.overloaded(obj, "copy", Nil, NamedArg(field, value) :: Nil)
2323

2424
parts match {
2525
case field :: Nil => helper(obj, value, field)
@@ -118,7 +118,7 @@ object Iso {
118118
// (p: S) => p._1
119119
val to = (p: S) => ${ Select.unique(('p).unseal, "_1").seal.cast[A] }
120120
// (p: A) => S(p)
121-
val from = (p: A) => ${ Select.overloaded(Ident(companion), "apply", Nil, ('p).unseal :: Nil, TypeBounds.minmax).seal.cast[S] }
121+
val from = (p: A) => ${ Select.overloaded(Ident(companion), "apply", Nil, ('p).unseal :: Nil).seal.cast[S] }
122122
apply(from)(to)
123123
}
124124
}
@@ -147,7 +147,7 @@ object Iso {
147147
case TypeRef(prefix, name) => TermRef(prefix, name)
148148
}
149149

150-
val obj = Select.overloaded(Ident(companion), "apply", Nil, Nil, TypeBounds.minmax).seal.cast[S]
150+
val obj = Select.overloaded(Ident(companion), "apply", Nil, Nil).seal.cast[S]
151151

152152
'{
153153
Iso[S, 1](Function.const($obj))(Function.const(1))

tests/run-macros/i6171/Macro_1.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ object scalatest {
1616
case t @ Apply(Select(lhs, op), rhs :: Nil) =>
1717
let(lhs) { left =>
1818
let(rhs) { right =>
19-
val app = Select.overloaded(left, op, Nil, right :: Nil, TypeBounds.minmax)
19+
val app = Select.overloaded(left, op, Nil, right :: Nil)
2020
let(app) { result =>
2121
val l = left.seal
2222
val r = right.seal
@@ -30,7 +30,7 @@ object scalatest {
3030
if isImplicitMethodType(f.tpe) =>
3131
let(lhs) { left =>
3232
let(rhs) { right =>
33-
val app = Select.overloaded(Apply(qual, left :: Nil), op, Nil, right :: Nil, TypeBounds.minmax)
33+
val app = Select.overloaded(Apply(qual, left :: Nil), op, Nil, right :: Nil)
3434
let(Apply(app, implicits)) { result =>
3535
val l = left.seal
3636
val r = right.seal

tests/run-macros/reflect-pos-fun/assert_1.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ object scalatest {
1212
case t @ Apply(TypeApply(Select(lhs, op), targs), rhs) =>
1313
let(lhs) { left =>
1414
lets(rhs) { rs =>
15-
val app = Select.overloaded(left, op, targs.map(_.tpe), rs, TypeBounds.minmax)
15+
val app = Select.overloaded(left, op, targs.map(_.tpe), rs)
1616
val b = app.seal.cast[Boolean]
1717
'{ scala.Predef.assert($b) }.unseal
1818
}

tests/run-macros/reflect-select-constructor/assert_1.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ object scalatest {
1616
case t @ Apply(Select(lhs, op), rhs :: Nil) =>
1717
let(lhs) { left =>
1818
let(rhs) { right =>
19-
val app = Select.overloaded(left, op, Nil, right :: Nil, TypeBounds.minmax)
19+
val app = Select.overloaded(left, op, Nil, right :: Nil)
2020
let(app) { result =>
2121
val l = left.seal
2222
val r = right.seal
@@ -30,7 +30,7 @@ object scalatest {
3030
if isImplicitMethodType(f.tpe) =>
3131
let(lhs) { left =>
3232
let(rhs) { right =>
33-
val app = Select.overloaded(Apply(qual, left :: Nil), op, Nil, right :: Nil, TypeBounds.minmax)
33+
val app = Select.overloaded(Apply(qual, left :: Nil), op, Nil, right :: Nil)
3434
let(Apply(app, implicits)) { result =>
3535
val l = left.seal
3636
val r = right.seal

tests/run-macros/reflect-select-value-class/assert_1.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ object scalatest {
1616
case t @ Apply(Select(lhs, op), rhs :: Nil) =>
1717
let(lhs) { left =>
1818
let(rhs) { right =>
19-
val app = Select.overloaded(left, op, Nil, right :: Nil, TypeBounds.minmax)
19+
val app = Select.overloaded(left, op, Nil, right :: Nil)
2020
let(app) { result =>
2121
val l = left.seal
2222
val r = right.seal
@@ -30,7 +30,7 @@ object scalatest {
3030
if isImplicitMethodType(f.tpe) =>
3131
let(lhs) { left =>
3232
let(rhs) { right =>
33-
val app = Select.overloaded(Apply(qual, left :: Nil), op, Nil, right :: Nil, TypeBounds.minmax)
33+
val app = Select.overloaded(Apply(qual, left :: Nil), op, Nil, right :: Nil)
3434
let(Apply(app, implicits)) { result =>
3535
val l = left.seal
3636
val r = right.seal

0 commit comments

Comments
 (0)