sourcepath: avoid warnings spanning a whole class

Author: smarter

compiler/src/dotty/tools/dotc/core/SymbolLoaders.scala

@@ -131,7 +131,7 @@ object SymbolLoaders {
             ctx.warning(i"""$what ${tree.name} is in the wrong directory.
                               |It was declared to be in package ${path.reverse.mkString(".")}
                               |But it is found in directory     ${filePath.reverse.mkString(File.separator)}""",
-              tree.sourcePos)
+              tree.sourcePos.focus)
           ok
         }
 

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -136,6 +136,7 @@ class CompilationTests extends ParallelTesting {
       compileFile("tests/neg-custom-args/i3627.scala", allowDeepSubtypes),
       compileFile("tests/neg-custom-args/matchtype-loop.scala", allowDeepSubtypes),
       compileFile("tests/neg-custom-args/sourcepath/outer/nested/Test1.scala", defaultOptions.and("-sourcepath", "tests/neg-custom-args/sourcepath")),
+      compileDir("tests/neg-custom-args/sourcepath2/hi", defaultOptions.and("-sourcepath", "tests/neg-custom-args/sourcepath2", "-Xfatal-warnings")),
       compileList("duplicate source", List(
         "tests/neg-custom-args/toplevel-samesource/S.scala",
         "tests/neg-custom-args/toplevel-samesource/nested/S.scala"),

tests/neg-custom-args/sourcepath2/hi/A.check

@@ -0,0 +1,6 @@
+-- Error: tests/neg-custom-args/sourcepath2/hi/A.scala:3:6 -------------------------------------------------------------
+3 |class Hello { // error
+  |      ^
+  |      class Hello is in the wrong directory.
+  |      It was declared to be in package <empty>
+  |      But it is found in directory     hi

tests/neg-custom-args/sourcepath2/hi/A.scala

@@ -0,0 +1,5 @@
+// Missing `package hi`
+
+class Hello { // error
+  val x: Int = 1
+}

tests/neg-custom-args/sourcepath2/hi/B.scala

@@ -0,0 +1,2 @@
+package hi
+class B