Get rid of NotPrivate flag.

It is now redundant.

Author: odersky

src/dotty/tools/dotc/core/Flags.scala

@@ -367,9 +367,6 @@ object Flags {
   /** Symbol is defined in a super call */
   final val InSuperCall = commonFlag(46, "<in supercall>")
 
-  /** Symbol with private access is accessed outside its private scope */
-  final val NotJavaPrivate = commonFlag(47, "<not-java-private>")
-
   /** Denotation is in train of being loaded and completed, used to catch cyclic dependencies */
   final val Touched = commonFlag(48, "<touched>")
 

src/dotty/tools/dotc/transform/Constructors.scala

@@ -56,7 +56,7 @@ class Constructors extends MiniPhaseTransform with SymTransformer { thisTransfor
   private def mightBeDropped(sym: Symbol)(implicit ctx: Context) =
     sym.is(Private, butNot = KeeperFlags) && !sym.is(MutableParamAccessor)
 
-  private final val KeeperFlags = Method | Lazy | NotJavaPrivate
+  private final val KeeperFlags = Method | Lazy
   private final val MutableParamAccessor = allOf(Mutable, ParamAccessor)
 
   override def transformTemplate(tree: Template)(implicit ctx: Context, info: TransformerInfo): Tree = {

src/dotty/tools/dotc/transform/LambdaLift.scala

@@ -290,11 +290,10 @@ class LambdaLift extends MiniPhase with IdentityDenotTransformer { thisTransform
         val (newOwner, maybeStatic) =
           if (lOwner is Package) (local.topLevelClass, JavaStatic)
           else (lOwner, EmptyFlags)
-        val maybeNotJavaPrivate = if (calledFromInner(local)) NotJavaPrivate else EmptyFlags
         local.copySymDenotation(
           owner = newOwner,
           name = newName(local),
-          initFlags = local.flags &~ InSuperCall | Private | maybeStatic | maybeNotJavaPrivate,
+          initFlags = local.flags &~ InSuperCall | Private | maybeStatic,
           info = liftedInfo(local)).installAfter(thisTransform)
         if (local.isClass)
           for (member <- local.asClass.info.decls)

src/dotty/tools/dotc/transform/PrivateToStatic.scala

@@ -33,7 +33,7 @@ class PrivateToStatic extends MiniPhase with SymTransformer { thisTransform =>
   def shouldBeStatic(sd: SymDenotation)(implicit ctx: Context) =
     sd.current(ctx.withPhase(thisTransform)).asSymDenotation
       .is(PrivateMethod, butNot = Immovable) &&
-    (sd.owner.is(Trait) || sd.is(NotJavaPrivate))
+    sd.owner.is(Trait)
 
   override def transformSym(sd: SymDenotation)(implicit ctx: Context): SymDenotation =
     if (shouldBeStatic(sd)) {