Micro-optimization for denotAt

odersky · odersky · commit 6251b8e926ba · 2018-03-07T12:29:25.000+01:00
diff --git a/compiler/src/dotty/tools/dotc/core/Types.scala b/compiler/src/dotty/tools/dotc/core/Types.scala
@@ -1691,7 +1691,7 @@ object Types {
      *  attempt in `denot` does not yield a denotation.
      */
     private def denotAt(lastd: Denotation, now: Period)(implicit ctx: Context): Denotation = {
-      if (lastd != null && (lastd.validFor contains now) && checkedPeriod != Nowhere) {
+      if (checkedPeriod != Nowhere && lastd.validFor.contains(now)) {
         checkedPeriod = now
         lastd
       }

Original file line number	Diff line number	Diff line change
`@@ -1691,7 +1691,7 @@ object Types {`
`1691`	`1691`	* attempt in `denot` does not yield a denotation.
`1692`	`1692`	`*/`
`1693`	`1693`	`private def denotAt(lastd: Denotation, now: Period)(implicit ctx: Context): Denotation = {`
`1694`		`- if (lastd != null && (lastd.validFor contains now) && checkedPeriod != Nowhere) {`
	`1694`	`+ if (checkedPeriod != Nowhere && lastd.validFor.contains(now)) {`
`1695`	`1695`	`checkedPeriod = now`
`1696`	`1696`	`lastd`
`1697`	`1697`	`}`