Scala3doc: document stdlib together with Dotty extensions

Author: abgruszecki

compiler/src/dotty/tools/dotc/typer/TypeAssigner.scala

@@ -299,6 +299,12 @@ trait TypeAssigner {
           else fntpe.resultType
         else
           errorType(i"wrong number of arguments at ${ctx.phase.prev} for $fntpe: ${fn.tpe}, expected: ${fntpe.paramInfos.length}, found: ${args.length}", tree.srcPos)
+      case t if args.isEmpty =>
+        // NOTE this case is necessary when loading the stdlib from Tasty. Our extensions are compiled with stdlib loaded
+        // from Scala2 classfiles while they are loaded with stdlib loaded from Tasty. This results in `def toString` being
+        // typed as MethodType in the first case and ExprType in the second case. In the second case (and, I think, only then)
+        // we need to handle ExprType being present here.
+        t
       case t =>
         if (ctx.settings.Ydebug.value) new FatalError("").printStackTrace()
         errorType(err.takesNoParamsStr(fn, ""), tree.srcPos)

project/Build.scala

@@ -1491,7 +1491,7 @@ object Build {
       }
 
       def joinProducts(products: Seq[java.io.File]): String =
-        products.iterator.map(_.getAbsolutePath.toString).mkString(java.io.File.pathSeparator)
+        products.iterator.map(_.getAbsolutePath.toString).mkString(" ")
 
       val dokkaVersion = "1.4.10.2"
 
@@ -1539,7 +1539,7 @@ object Build {
               (`scala3-library-bootstrapped`/Compile/products).value,
             ).flatten
 
-            val roots = dottyJars.mkString(" ")
+            val roots = joinProducts(dottyJars)
 
             if (dottyJars.isEmpty) Def.task { streams.value.log.error("Dotty lib wasn't found") }
             else Def.task{
@@ -1555,6 +1555,7 @@ object Build {
 
           generateScala3StdlibDocumentation:= Def.taskDyn {
             val dottyJars: Seq[java.io.File] = Seq(
+              (`scala3-library-bootstrapped`/Compile/products).value,
               (`stdlib-bootstrapped`/Compile/products).value,
             ).flatten