Skip to content

Commit 74895f0

Browse files
committed
change default filters behavior
1 parent b37a429 commit 74895f0

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

scaladoc/resources/dotty_res/scripts/components/DocumentableList.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* @typedef { [key: string, value: string][] } Dataset
55
*/
66

7-
class DocumentableList extends Component {
7+
class DocumentableList extends Component {
88
constructor(props) {
99
super(props);
1010

@@ -140,7 +140,7 @@ class List {
140140

141141
function includesInputValue() {
142142
const lcValue = filter.value.toLowerCase()
143-
return elementData.name.toLowerCase().includes(lcValue)
143+
return elementData.name.toLowerCase().includes(lcValue)
144144
|| elementData.description.toLowerCase().includes(lcValue);
145145
}
146146

@@ -177,7 +177,9 @@ class List {
177177
.every(([filterKey, value]) => {
178178
const filterGroup = filter.filters[filterKey]
179179

180-
return value.split(",").some(v => filterGroup && filterGroup[v].selected)
180+
console.log(Object.entries(filterGroup).filter(arr => arr[1].selected))
181+
182+
return Object.entries(filterGroup).filter(arr => arr[1].selected).length == 0 || value.split(",").some(v => (filterGroup && filterGroup[v].selected))
181183
})
182184

183185
return isVisible

scaladoc/resources/dotty_res/scripts/components/Filter.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* @typedef { Record<FilterAttributes, FilterMap> } Filters
55
*/
66

7-
class Filter {
7+
class Filter {
88
/**
99
* @param value { string }
1010
* @param filters { Filters }
@@ -217,8 +217,8 @@ class Filter {
217217
}
218218

219219
class FilterItem {
220-
constructor(selected = true, visible = true) {
220+
constructor(selected = false, visible = true) {
221221
this.selected = selected
222222
this.visible = visible
223223
}
224-
}
224+
}

0 commit comments

Comments
 (0)