Add more debugging

Author: jan-pieter

compiler/src/dotty/tools/dotc/typer/CrossVersionChecks.scala

@@ -26,8 +26,8 @@ class CrossVersionChecks extends MiniPhase:
   // I assume that's a consequence of some code trying to avoid noise by suppressing
   // warnings after the first, but I think it'd be better if we didn't have to
   // arbitrarily choose one as more important than the other.
-  private def checkUndesiredProperties(sym: Symbol, pos: SrcPos)(using Context): Unit =
-    checkDeprecated(sym, pos)
+  private def checkUndesiredProperties(sym: Symbol, pos: SrcPos, site: String)(using Context): Unit =
+    checkDeprecated(sym, pos, site)
     checkExperimentalRef(sym, pos)
 
     val xMigrationValue = ctx.settings.Xmigration.value
@@ -38,7 +38,7 @@ class CrossVersionChecks extends MiniPhase:
   /** If @deprecated is present, and the point of reference is not enclosed
    * in either a deprecated member or a scala bridge method, issue a warning.
    */
-  private def checkDeprecated(sym: Symbol, pos: SrcPos)(using Context): Unit =
+  private def checkDeprecated(sym: Symbol, pos: SrcPos, site: String)(using Context): Unit =
 
     /** is the owner an enum or its companion and also the owner of sym */
     def isEnumOwner(owner: Symbol)(using Context) =
@@ -63,11 +63,11 @@ class CrossVersionChecks extends MiniPhase:
     def skipWarning(using Context): Boolean = {
       val owners = ctx.owner.ownersIterator.toList
       val result = //(sym.isConstructor && sym.owner.is(Flags.CaseClass) && ctx.owner.is(Flags.Synthetic)) &&
-        owners.exists(owner => if sym.isEnumCase then isDeprecatedOrEnum(owner) else ctx.owner.is(Flags.Synthetic) || owner.isDeprecated)
-      if (!result)
-        println(i"sym: $sym flags: ${sym.flagsString}")
-        println(i"owner: ${ctx.owner} deprecated: ${ctx.owner.isDeprecated} constructor: ${ctx.owner.isConstructor} flags: ${ctx.owner.flagsString}")
-        println(i"tree: ${ctx.tree}")
+        (ctx.owner.is(Flags.Synthetic) && sym.is(Flags.CaseClass)) ||
+        owners.exists(owner => if sym.isEnumCase then isDeprecatedOrEnum(owner) else owner.isDeprecated)
+      println(i"sym: $sym flags: ${sym.flagsString} owner: ${sym.owner} constructor: ${sym.isConstructor}")
+      println(i"owner: ${ctx.owner} deprecated: ${ctx.owner.isDeprecated} constructor: ${ctx.owner.isConstructor} flags: ${ctx.owner.flagsString}")
+      println(i"site: $site")
       result
     }
 
@@ -137,28 +137,28 @@ class CrossVersionChecks extends MiniPhase:
     tree
 
   override def transformIdent(tree: Ident)(using Context): Ident = {
-    checkUndesiredProperties(tree.symbol, tree.srcPos)
+    checkUndesiredProperties(tree.symbol, tree.srcPos, "ident")
     tree
   }
 
   override def transformSelect(tree: Select)(using Context): Select = {
-    checkUndesiredProperties(tree.symbol, tree.srcPos)
+    checkUndesiredProperties(tree.symbol, tree.srcPos, "select")
     tree
   }
 
   override def transformNew(tree: New)(using Context): New = {
-    checkUndesiredProperties(tree.tpe.typeSymbol, tree.srcPos)
+    checkUndesiredProperties(tree.tpe.typeSymbol, tree.srcPos, "new")
     tree
   }
 
   override def transformTypeTree(tree: TypeTree)(using Context): TypeTree = {
     val tpe = tree.tpe
     tpe.foreachPart {
       case TypeRef(_, sym: Symbol)  =>
-        checkDeprecated(sym, tree.srcPos)
+        checkDeprecated(sym, tree.srcPos, "typeTree.typeRef")
         checkExperimentalRef(sym, tree.srcPos)
       case TermRef(_, sym: Symbol)  =>
-        checkDeprecated(sym, tree.srcPos)
+        checkDeprecated(sym, tree.srcPos, "typeTree.termRef")
         checkExperimentalRef(sym, tree.srcPos)
       case _ =>
     }
@@ -173,7 +173,7 @@ class CrossVersionChecks extends MiniPhase:
   override def transformOther(tree: Tree)(using Context): Tree = tree match
     case tree: Import =>
       tree.foreachSubTree {
-        case t: RefTree => checkUndesiredProperties(t.symbol, t.srcPos)
+        case t: RefTree => checkUndesiredProperties(t.symbol, t.srcPos, "other")
         case _ =>
       }
       tree